Giter VIP home page Giter VIP logo

Comments (5)

ishanarya0 avatar ishanarya0 commented on May 29, 2024 2

wanted to discuss this here as well, about how we should pass id in commands. In some view commands we are passing id as an argument while in others (edit, appeal revoke, etc.) we are using --id flag.

Can we standardize all commands to pick id from args? so it'll look like these:

- guardian provider edit --id=1234 --file=./provider.yaml
+ guardian provider edit 1234 --file=./provider.yaml

- guardian appeal revoke --id=1234 --reason=""
+ guardian appeal revoke 1234 --reason=""

etc.

Yes, that looks better! I'll do the changes.

from guardian.

ishanarya0 avatar ishanarya0 commented on May 29, 2024 1

@ravisuhag The init command needs to generate a generic template for policy or provider?

Command: guardian provider/policy init --name=<file-name>

from guardian.

ravisuhag avatar ravisuhag commented on May 29, 2024 1

@ishanarya0 yes, but let pull the templates folder out of cmd.

from guardian.

rahmatrhd avatar rahmatrhd commented on May 29, 2024 1

wanted to discuss this here as well, about how we should pass id in commands. In some view commands we are passing id as an argument while in others (edit, appeal revoke, etc.) we are using --id flag.

Can we standardize all commands to pick id from args? so it'll look like these:

- guardian provider edit --id=1234 --file=./provider.yaml
+ guardian provider edit 1234 --file=./provider.yaml

- guardian appeal revoke --id=1234 --reason=""
+ guardian appeal revoke 1234 --reason=""

etc.

from guardian.

ishanarya0 avatar ishanarya0 commented on May 29, 2024

@ravisuhag Can we go by this generic initialization? Link

from guardian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.