Comments (5)
wanted to discuss this here as well, about how we should pass
id
in commands. In someview
commands we are passingid
as an argument while in others (edit
,appeal revoke
, etc.) we are using--id
flag.Can we standardize all commands to pick
id
from args? so it'll look like these:- guardian provider edit --id=1234 --file=./provider.yaml + guardian provider edit 1234 --file=./provider.yaml - guardian appeal revoke --id=1234 --reason="" + guardian appeal revoke 1234 --reason="" etc.
Yes, that looks better! I'll do the changes.
from guardian.
@ravisuhag The init command needs to generate a generic template for policy or provider?
Command: guardian provider/policy init --name=<file-name>
from guardian.
@ishanarya0 yes, but let pull the templates folder out of cmd.
from guardian.
wanted to discuss this here as well, about how we should pass id
in commands. In some view
commands we are passing id
as an argument while in others (edit
, appeal revoke
, etc.) we are using --id
flag.
Can we standardize all commands to pick id
from args? so it'll look like these:
- guardian provider edit --id=1234 --file=./provider.yaml
+ guardian provider edit 1234 --file=./provider.yaml
- guardian appeal revoke --id=1234 --reason=""
+ guardian appeal revoke 1234 --reason=""
etc.
from guardian.
@ravisuhag Can we go by this generic initialization? Link
from guardian.
Related Issues (20)
- Able to change the policy for pending appeals HOT 1
- refactor appeal functions HOT 3
- Add resources conditionally
- Only allowed a few roles on Bigquery Dataset HOT 2
- Register Dataplex policy-tags as provider HOT 5
- Getting 3 times slack notification for same resource reminder HOT 2
- Shield as a provider in Guardian
- ability to trigger jobs through API end point HOT 1
- support `account_id` in grant expiry reminder notification
- Use `go install` in make setup instead of `go get`
- bigquery get activities test case is flaky
- bigquery client throwing error `CREDENTIALS_MISSING` HOT 3
- Add authentication to guardian using google idtoken (from google SSO login) HOT 18
- Disable dockertest on repository test during unit test HOT 2
- Add API to assign/update owner of a grant HOT 8
- Guardian Approval through Slack HOT 11
- bug(gcs): fetch resources not working for some gcs providers
- Multiple owners in Grants
- Fetch labels for bigquery dataset/table HOT 2
- Frontier provider get groups api needs to be refactored to get admin/owners list
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guardian.