Giter VIP home page Giter VIP logo

Comments (6)

RazrFalcon avatar RazrFalcon commented on May 25, 2024

You should use owned-ttf-parser instead.

Is font parse not one-time action?

No. ttf-parser parses the font parts on demand. Parsing the whole font into the memory is absurd and no one is doing this.

The lifetime is required, since Face doesn't allocate anything (at least on heap). At all.

from ttf-parser.

bennoinbeta avatar bennoinbeta commented on May 25, 2024

You should use owned-ttf-parser instead.

Is font parse not one-time action?

No. ttf-parser parses the font parts on demand. Parsing the whole font into the memory is absurd and no one is doing this.

The lifetime is required, since Face doesn't allocate anything (at least on heap). At all.

Hey @RazrFalcon ,
I'm currently utilizing ttf-parser and exploring the possibility of caching the Face object for repeated use. Below is a snippet of my current implementation (which didn't work out due to the lifetime constraints and the fact that I'm no experienced Rust developer yet):

#[derive(Resource, Default)]
pub struct FontCacheRes {
    font_content: HashMap<u64, CachedFont>,
}

#[derive(Default)]
pub struct CachedFont {
    pub content: Vec<u8>,
    // https://github.com/RazrFalcon/ttf-parser/issues/37
    // pub face: Option<Face>, // TODO: Cache Face?
    pub font: Font,
}

impl CachedFont {
    // pub fn get_or_create_face(&'a mut self) -> &'a Face<'a> {
    //     if self.face.is_none() {
    //         self.face = Face::from_slice(&self.content, 0);
    //     }
    //     self.face.as_ref().unwrap()
    // }
}

Given the lifetime requirements of Face, I'm debating whether caching the Face makes any sense or if there's a recommended practice for handling such scenarios. Is it advisable to cache Face within a struct, or should I reparse the font data each time it's required? Insights or best practices on this matter would be very helpful.

Thanks :)

from ttf-parser.

RazrFalcon avatar RazrFalcon commented on May 25, 2024

As the comment above mentioned - just use owned-ttf-parser.

And yes, depending on your performance requirements you might be fine with re-parsing the Face on each access.
Face::parse doesn't actually parse the whole font, only some basic metadata.

from ttf-parser.

bennoinbeta avatar bennoinbeta commented on May 25, 2024

As the comment above mentioned - just use owned-ttf-parser.

And yes, depending on your performance requirements you might be fine with re-parsing the Face on each access. Face::parse doesn't actually parse the whole font, only some basic metadata.

thanks for the quick reply 🙏 Can I use owned-ttf-parser with rustybuzz though?

from ttf-parser.

RazrFalcon avatar RazrFalcon commented on May 25, 2024

Yes. owned-ttf-parser is just a wrapper for ttf-parser. See docs.

from ttf-parser.

bennoinbeta avatar bennoinbeta commented on May 25, 2024

Yes. owned-ttf-parser is just a wrapper for ttf-parser. See docs.

Thanks for the quick information. I'll explore both caching and not caching the Face to see what works best for my SVG text rendering project. Also, a big thanks for developing rustybuzz & ttf-parser – it looks like a great fit for my needs 👍🙏

from ttf-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.