Comments (11)
Oh yeah, the url to the standard:
http://www.w3.org/html/wg/html5/#scrollintoview
it doesn't mention horizontal scrolling.
Original comment by [email protected]
on 21 Jul 2007 at 8:50
from base2.
If it is only a few lines of code then by all means code it up. If it requires
a lot
of code then I don't consider it important enough to include in base2.DOM. You
can
alway write it as an optional Module if that is the case. Maybe DOM/extras is
something we should create either way?
Original comment by [email protected]
on 23 Jul 2007 at 9:04
- Added labels: Priority-Low
- Removed labels: Priority-Medium
from base2.
DOM/extras it is. We can always merge it with DOM later.
Original comment by [email protected]
on 23 Jul 2007 at 9:21
from base2.
Hey. If scrollIntoView fix is only a couple of lines it can still go in
base2.DOM
core. But It would be nice to have some /extras/ for other stuff.
Or we can namespace it (with lazy loading in mind).
e.g. base2.use(DOM.Element.scrollIntoView);
Which would mean that the code lived here:
/svn/version/whatever/DOM/HTMLElement/scrollIntoView.js
Thoughts?
Original comment by [email protected]
on 23 Jul 2007 at 9:54
from base2.
I will come up with my javascript builder idea shortly. Then we talk.
The code for scrollIntoView at the moment is:
---8<----------------------------------------------------------------------
function GetWindowHeight() {
return window.innerHeight||document.documentElement&&document.documentElement.clientHeight||document.body.clientHeight||0;
}
function GetScrollTop() {
return window.pageYOffset||document.documentElement&&document.documentElement.scrollTop || document.body.scrollTop||0;
}
function GetTop(element) {
var pos=0;
do pos+=element.offsetTop
while(element=element.offsetParent);
return pos;
}
function InView(element,margin) {
if(typeof element=='string') element=$(element);
if(!margin) margin=0;
var Top=GetTop(element), ScrollTop=GetScrollTop();
return !(Top<ScrollTop+margin || Top>ScrollTop+GetWindowHeight()-element.offsetHeight-margin);
}
function ScrollIntoView(element,bAlignTop,margin) {
if(typeof element=='string') element=$(element);
if(!margin) margin=0;
var posY=GetTop(element);
if(bAlignTop) posY-=margin;
else posY+=element.offsetHeight+margin-GetWindowHeight();
window.scrollTo(0, posY);
}
---8<----------------------------------------------------------------------
to long?
Original comment by [email protected]
on 23 Jul 2007 at 10:06
from base2.
Too long.
Original comment by [email protected]
on 23 Jul 2007 at 1:06
from base2.
That too ;-)
Original comment by [email protected]
on 23 Jul 2007 at 3:42
from base2.
We could create DOM/HTML5, and also move getElementsByClassName to there, and
implement:
irrelevant, draggable there. But I for starters, I implement the DOM/strict way.
Original comment by [email protected]
on 23 Jul 2007 at 10:02
from base2.
I've added the code to DOM/extras for the moment. One note about the
enhancement. I just found out all
modern browsers support it. Probably an early version of Safari 2 didn't
support it, and Opera8 en Firefox1. But
it's good to have it.
Shall we rename extras to html5?
Original comment by [email protected]
on 23 Jul 2007 at 11:07
- Changed state: Started
from base2.
I'm not sure I want to start an HTML5 project just yet. It will just give people
ideas. Leave the code in extras for the time being. It may become useful later.
But
what we really need is documentation! :-)
Original comment by [email protected]
on 24 Jul 2007 at 12:38
from base2.
The code is in subversion, but there's a bug: doesn't work on
overflow+fixed-height elements.
I'll pick this up later, since this is actually a legacy enhancement.
Original comment by [email protected]
on 27 Jul 2007 at 11:24
from base2.
Related Issues (20)
- Please add Array2.make HOT 2
- 'Unspecified error' when loading a page via iframe in IE8.
- Function.bind() defined in Firefox 4 conflicts with Base2's own bind()s. HOT 1
- base62 encoding shrinked script fails with 3.1 but works with 3.0 HOT 3
- Contact to the owner of the project? HOT 1
- DOMContentLoaded does not fire in Safari 3.0.4 (and possibly other versions) HOT 1
- IE throws "Unspecified Error" when calling some methods or accessing some properties of elements not attached to a document
- base2.jsb.eventDispatcher fails to dispatch (delegated?) events under IE9
- Listeners for (before)?(cut|copy|paste) events are not executed in IE7-9 HOT 1
- Patch for /trunk/src/apps/MiniWeb/Client.js
- Patch for /trunk/src/apps/MiniWeb/Client.js
- document not geting extended.
- getting opacity in getComputedPropertyValue of ViewCSS returns empty string on element without opacity set
- Eclipse "Syntax error on token "new", ArrayLiteralHeader expected after this token", l. 19 of v1.0.2 of base2.js HOT 3
- Consider relying on HTML ClassList API
- :checked pseudo-class doesn't match selected option elements.
- Non ascii strings broken when encoded HOT 1
- classList.remove can incorrectly trigger IE's onpropertychange event.
- Allow Base cast specialization HOT 1
- Patch for /trunk/src/apps/packer/Base62.js HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base2.