Comments (16)
tgrospic
commented on July 30, 2024
@ian-bloom It's strange that you have - sign in front of commit hash for rchain/rvote.
I just tried to clone and start both repositories and they work as expected.
Can you try rchain/rvote from scratch?
# Clone with submodules
git clone --recurse-submodules https://github.com/rchain/rvote
# Install dependencies
npm install
# Start
npm startThis is my result for submodule status on rchain/rvote.
$ git submodule status
72931bedd2c66cc83e437f34f9ab7f3a8a0ba76f src/vendor/rnode-client-js (heads/master)from rvote.
ian-bloom
commented on July 30, 2024
@tgrospic I get the same exact result after clone from scratch:ℹ ｢wdm｣: Failed to compile.😢
The difference between the repos:
rv2020/src/vendor/ directory points to:
rnode-client-js @ 2c14d0a
all compiles nicely for me here
rchain/src/vendor/ directory points to:
rnode-client-js @ 72931be
here I get compilation problems
from rvote.
tgrospic
commented on July 30, 2024
@ian-bloom Hm, I didn't look carefully. The server is started but I also see errors in compilation.
ERROR in ./src/vendor/rnode-client-js/src/eth/eth-sign.js
Module not found: Error: Can't resolve '../../rnode-grpc-gen/js/pbjs_generated.json' in '/home/tomi/projects/rchain/rvote/src/vendor/rnode-client-js/src/eth'
@ ./src/vendor/rnode-client-js/src/eth/eth-sign.js 6:0-69 25:43-54
@ ./src/vendor/rnode-client-js/src/rnode-web.js
@ ./src/web/ballot.js
@ ./src/index.js
ERROR in ./src/vendor/rnode-client-js/src/rnode-web.js
Module not found: Error: Can't resolve '../rnode-grpc-gen/js/pbjs_generated.json' in '/home/tomi/projects/rchain/rvote/src/vendor/rnode-client-js/src'
@ ./src/vendor/rnode-client-js/src/rnode-web.js 10:0-66 47:45-56 200:65-76
@ ./src/web/ballot.js
@ ./src/index.js
ERROR in ./src/web/ballot.js
Module not found: Error: Can't resolve '../vendor/rnode-client-js/src/rev-address' in '/home/tomi/projects/rchain/rvote/src/web'
@ ./src/web/ballot.js 18:0-75 316:22-36
@ ./src/index.js
ERROR in ./src/web/ballot.js
Module not found: Error: Can't resolve '../vendor/rnode-client-js/src/web/rnode-actions' in '/home/tomi/projects/rchain/rvote/src/web'
@ ./src/web/ballot.js 10:0-13:57 405:9-20 442:28-44
@ ./src/index.js
ERROR in ./src/vendor/rnode-client-js/src/rnode-web.js
Module not found: Error: Can't resolve '@tgrospic/rnode-grpc-js' in '/home/tomi/projects/rchain/rvote/src/vendor/rnode-client-js/src'
@ ./src/vendor/rnode-client-js/src/rnode-web.js 7:0-95 47:30-43 74:20-30 76:24-36 201:24-36
@ ./src/web/ballot.js
@ ./src/index.js
ERROR in ./src/vendor/rnode-client-js/src/eth/eth-sign.js
Module not found: Error: Can't resolve '@tgrospic/rnode-grpc-js' in '/home/tomi/projects/rchain/rvote/src/vendor/rnode-client-js/src/eth'
@ ./src/vendor/rnode-client-js/src/eth/eth-sign.js 3:0-55 25:28-41
@ ./src/vendor/rnode-client-js/src/rnode-web.js
@ ./src/web/ballot.js
@ ./src/index.js
ERROR in ./src/vendor/rnode-client-js/src/rnode-web.js
Module not found: Error: Can't resolve 'grpc-web' in '/home/tomi/projects/rchain/rvote/src/vendor/rnode-client-js/src'
@ ./src/vendor/rnode-client-js/src/rnode-web.js 4:0-30 200:31-38
@ ./src/web/ballot.js
@ ./src/index.js
from rvote.
jimscarver
commented on July 30, 2024
I get failure also with submodule 72931bedd2c66cc...
from rvote.
tgrospic
commented on July 30, 2024
@ian-bloom I'm not sure how this can work because version in rchain-community/rnode-client-js is too old and e.g. it doesn't have rnode-actions.js which is used ballot.js.
from rvote.
jimscarver
commented on July 30, 2024
https://github.com/rchain-community/rv2020 definatly works. it does not use rnode-client-js from rchain-community.
from rvote.
tgrospic
commented on July 30, 2024
I synched rchain-community/rnode-client-js repo to tgrospic/rnode-client-js.
from rvote.
ian-bloom
commented on July 30, 2024
@jimscarver - rv2020 uses rchain-community version of rnode-client-js
rnode-client-js @ 2c14d0a
from rvote.
tgrospic
commented on July 30, 2024
It seems that was enough to resolve compilations errors. I see now that rchain-community/rv2020 starts correctly.
$ npm start
> [email protected] start /home/tomi/projects/rchain/rv2020
> webpack-dev-server --open
ℹ ｢wds｣: Project is running at http://localhost:8080/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from ./dist
ℹ ｢wdm｣: wait until bundle finished: /
ℹ ｢wdm｣: Hash: 5f92a3f296e5169cfb32
Version: webpack 4.44.2
Time: 1973ms
Built at: 2020-10-20 15:53:40
Asset Size Chunks Chunk Names
bundle.js 5.73 MiB main [emitted] main
index.html 7.66 KiB [emitted]
Entrypoint main = bundle.js
[0] multi (webpack)-dev-server/client?http://localhost:8080 (webpack)/hot/dev-server.js ./src/index.js 52 bytes {main} [built]
[./node_modules/shepherd.js/dist/js/shepherd.esm.js] 154 KiB {main} [built]
[./node_modules/webpack-dev-server/client/index.js?http://localhost:8080] (webpack)-dev-server/client?http://localhost:8080 4.29 KiB {main} [built]
[./node_modules/webpack-dev-server/client/overlay.js] (webpack)-dev-server/client/overlay.js 3.51 KiB {main} [built]
[./node_modules/webpack-dev-server/client/socket.js] (webpack)-dev-server/client/socket.js 1.53 KiB {main} [built]
[./node_modules/webpack-dev-server/client/utils/createSocketUrl.js] (webpack)-dev-server/client/utils/createSocketUrl.js 2.91 KiB {main} [built]
[./node_modules/webpack-dev-server/client/utils/log.js] (webpack)-dev-server/client/utils/log.js 964 bytes {main} [built]
[./node_modules/webpack-dev-server/client/utils/reloadApp.js] (webpack)-dev-server/client/utils/reloadApp.js 1.59 KiB {main} [built]
[./node_modules/webpack-dev-server/client/utils/sendMessage.js] (webpack)-dev-server/client/utils/sendMessage.js 402 bytes {main} [built]
[./node_modules/webpack-dev-server/node_modules/strip-ansi/index.js] (webpack)-dev-server/node_modules/strip-ansi/index.js 161 bytes {main} [built]
[./node_modules/webpack/hot sync ^\.\/log$] (webpack)/hot sync nonrecursive ^\.\/log$ 170 bytes {main} [built]
[./node_modules/webpack/hot/dev-server.js] (webpack)/hot/dev-server.js 1.59 KiB {main} [built]
[./node_modules/webpack/hot/emitter.js] (webpack)/hot/emitter.js 75 bytes {main} [built]
[./node_modules/webpack/hot/log-apply-result.js] (webpack)/hot/log-apply-result.js 1.27 KiB {main} [built]
[./src/index.js] 781 bytes {main} [built]
+ 536 hidden modules
Child HtmlWebpackCompiler:
1 asset
Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
[./node_modules/html-webpack-plugin/lib/loader.js!./src/web/index.html] 8.05 KiB {HtmlWebpackPlugin_0} [built]
ℹ ｢wdm｣: Compiled successfully.from rvote.
ian-bloom
commented on July 30, 2024
@tgrospic - That won't help.
Take a look at the rv2020/src/vendor/ directory inside of rchain-community/rv2020
rvote2020 uses old 2c14d0a commit to (work around ethUtil undefined problem with webpack?)
from rvote.
tgrospic
commented on July 30, 2024
@ian-bloom you are right, this reference commit 2c14d0a is not in master branch. I'm not sure why it not worked the first time and why it works after syncing the master.
from rvote.
tgrospic
commented on July 30, 2024
But on rchain/rvote reference is to different commit rnode-client-js @ 72931be which doesn't have Dan's changes
from rvote.
dckc
commented on July 30, 2024
@ian-bloom what was the purpose of e9532b9 ?
from rvote.
tgrospic
commented on July 30, 2024
@ian-bloom it seems that your commit 2 days ago made this change rchain@e9532b9.
from rvote.
ian-bloom
commented on July 30, 2024
I think that was from git submodule update --init that I ran as part of @dckc README.md
git clone https://github.com/rchain-community/rv2020
cd rv2020
git submodule update --init
npm install
npm start
from rvote.
ian-bloom
commented on July 30, 2024
Could I rebase to remove e9532b9 ?
I'm not sure the commands.
from rvote.
Related Issues (20)
- walkthru of voting rholang code HOT 16
- result not expected at top of page HOT 2
- user testing suggests questions should automatically come up HOT 1
- Load previous responses
- Limit voting to registered voters HOT 2
- verify chosen address is registered HOT 13
- send (at least) 1 REV to each registered REV address HOT 3
- submit starts multiple transactions in rxjs based code HOT 3
- multi-page UI HOT 7
- which browsers to support? notify / train uses to use chrome? HOT 2
- success marker is goofy HOT 2
- user testing for secretary role HOT 1
- banner looks goofy on mobile
- voting receipt: transaction id / deployId / signature
- plain English rendition of rholang vote (a la gpt-3) HOT 2
- setting ballot and registered voters set uri's HOT 1
- generative testing for tally.sh vs tally.sql
- tally in rholang HOT 1
- Fix URI's for new testnet.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rvote.