Unnecessary allocations per frame about lightning HOT 3 OPEN

In addition, to the allocations from the use of setUniform, a shader like RoundedRectangle allocate on every frame in the map function converting the radius to the final int32's.

from lightning.

Ugh that's bad. For some shaders the arrays could potentially be "cached"?

from lightning.

For some shaders the arrays can definitely be cached, but in a lot of cases they can also be entirely avoided if you add the exact functions you wanted to call rather than going through the API of setUniform that only allows a single value parameter

https://github.com/rdkcentral/Lightning/blob/master/src/renderer/webgl/shaders/RoundedRectangleShader.mjs#L145-L151
Those Float32Arrays are only necessary because of the setUniform API of currying the GL function to use only supports a single value for the glFunction.

If instead you had a setUniform[2,3,4]f, you could avoid all that heap allocation and just stack alloc making GC pressure a lot lower.

This largely doesn't matter until you have something animating on screen and then every rounded rect allocs 6 floats of garbage per frame.

from lightning.