Consider excluding built files from repo about react-bootstrap HOT 9 CLOSED

Yeah, thing is that you don't publish anything to Bower, it just gets the package from Github. We could have separate projects for the source and build?

from react-bootstrap.

That would work actually - a repo each for AMD + CommonJS + another for the source. I'll look into doing that.

from react-bootstrap.

Yeah sounds good having a separate repo for Bower, heres the react one for referance: https://github.com/facebook/react-bower

I wonder if it would be worth looking into using a UMD wrapper for the modules so we don't need the extra duplication of both AMD and CommonJS dirs, we could add this as a build step. React are looking to use pure-cjs for this facebook/react#1002

from react-bootstrap.

I'm not sure pure-cjs fits the bill. It seems to only wrap the top level module in UMD which wouldn't let you require specific components. I think its fine as it is if we add react-bootstrap-bower and react-bootstrap-npm repos.

Probably worth doing it at the same time as moving to an org as you have to write a nice letter to the Bower people to get them to move the package. What was that react component org you mentioned before?

from react-bootstrap.

Right yeah i thought might be the case, would you still include the cjs and amd dirs in both packages?

The react org is: https://github.com/reactjs.
Wow the bower people still haven't fixed that, guess that makes sense then.

from react-bootstrap.

No, I'd only include the built files for that module system in the root of the repo so no more amd and cjs dirs

from react-bootstrap.

Have published built packages for npm and bower at https://github.com/react-bootstrap

Will have to wait for Bower to update their db before removing the built files from here bower/bower#120

from react-bootstrap.

Nice work!

from react-bootstrap.

Right have got fed up waiting for Bower and removed the built files from here. They are now at https://github.com/react-bootstrap

from react-bootstrap.