NavBar about react-bootstrap HOT 9 CLOSED

Sorry this component has not been implemented yet. Currently the Nav component only supports Pills and Tabs. Pull requests welcome :)

from react-bootstrap.

Saw Steve committed a Navbar, so I integrated that into a Navbar implementation I've been working on which I just put into a react-bootstrap fork at https://github.com/ENCODE-DCC/react-bootstrap. I don’t know if it’s the model Steve was thinking of, but it uses Nav and NavItem, in this style:

<Navbar…>
  <Nav…>
    <NavItem…>Item 1</NavItem>
    <NavItem…>Item 2</NavItem>
  </Nav>
</Navbar>

Since our project needs dropdowns and forms, I integrated those too (though my Forms component barely does anything; I don’t want to delve any further into that). I modified both Nav and NavItem components to be aware of navbar and dropdown classes. So far, I have done minimal testing.

from react-bootstrap.

@forresttanaka thanks. I don't think I'll be adding this functionality into the library tho. I think the NavBar should remain more flexible. If the user wants to add a brand link and collapsible menu they can but I don't think we'll bake it in.

from react-bootstrap.

OK. Thanks for taking a look!

from react-bootstrap.

Think I will extend this a bit with brand and collapseNavKey props.

brand is a renderable and if present a navbar-header is added with the brand in.

If toggleNavKey is present, we add the navbar-toggle button which does the animation to the child with that key.

from react-bootstrap.

+1

from react-bootstrap.

brand and toggleNavKey have been added but I'm thinking of creating a Collapse component which would wrap a Nav instead of having the collapsing behaviour in the Nav itself. toggleNavKey would change to collapseKey I think.

from react-bootstrap.

@stevoland Is this resolved by #110 ?

from react-bootstrap.

@pieterv No it's not but I changed my mind about it. I think I'll leave it as it is. At least for now.

from react-bootstrap.