Consider implementing simple components about react-bootstrap HOT 35 CLOSED

Done #1707

from react-bootstrap.

It would be nice to have them as React components as in most cases it will mean you will end up with a little less JSX code, <Label bsStyle="primary">Primary</Label> seems nicer than <span class="label label-primary">Primary</span>. But yes there is certainly a trade off in that we will need to create and maintain this abstraction and even more time consuming will be documenting them :P

I like the idea of creating these (even with extremely minimal docs) but i guess it would be pretty low priority.

from react-bootstrap.

Yeah I'd like to add them. I was hoping this ticket would encourage someone else to help! :)

from react-bootstrap.

Cool, not many simple components left: Table, Pagination, Pager, Breadcrumb is about it

from react-bootstrap.

What about Media?

from react-bootstrap.

Yes, that one too. Obviously I'm not very good at reading documentation ;)

So: Media, Table, Pagination, Pager, Breadcrumb

Are there any others? I will hopefully have time to implement at these this weekend, clients be willing.

from react-bootstrap.

Nice, thanks!

Perhaps there is also Thumbnails. (Other than the ones for which there is a specific issue already opened)

There is Nav that's broken when displaying responsively, but I need to open a separate issue for that. Really looking forward to your additions!

from react-bootstrap.

And what is about the container element? I'm transforming a layout into react-bootstrap components right now and still need to import the bootstrap css file.

from react-bootstrap.

I'd like to do the Thumbnail if that's okay. I'm new to this repo but would love to get involved @mtscout6

from react-bootstrap.

@JordanTheriault That'd be great!

from react-bootstrap.

@mathieumg media is the worst Bootstrap part ever. It's totally broken in responsive aspect.
Not recommend.

from react-bootstrap.

@mtscout6 Do we add embeds? http://getbootstrap.com/components/#responsive-embed
images? http://getbootstrap.com/css/#images

from react-bootstrap.

Both of those seem reasonable.

from react-bootstrap.

should add affix to the list

#200

from react-bootstrap.

#488 resolves thumbnails

from react-bootstrap.

/cc @react-bootstrap/collaborators
Do we really want this issue as a condition for the Milestone 1.0.0 ?

In my opinion if nobody is interested in those additional components,
so there is no value to make them.

And Steve named topic as 'Consider..', i.e. it doesn't mean that they 'must' be implemented.

I propose to remove it from the Milestone 1.0.0. 🍒

from react-bootstrap.

I think they should be in 1.0, otherwise 1.0 wouldn't be 1.0. To me, 1.0 means "some stability" and "feature parity with Bootstrap". There is a need with regards to these components, but the implementation of some of them brings no challenge (or even benefits per se) to the table, probably a reason why they've been overlooked. Once we set to implement them, it shouldn't be too long, for most anyway.

from react-bootstrap.

Then:
We are working on getting through the backlogged tickets like this, but are short on time.
If anyone is interested and would like to help out we are very open to pull requests ❇️

from react-bootstrap.

yeah I have the same opinion as @mathieumg on this. 1.0 should mean parity.

from react-bootstrap.

Hi @dozoisch @mtscout6 I'm interested to help with images component. I'm working on it.

from react-bootstrap.

@deerawan awesome!

from react-bootstrap.

And.. here we are 😄 Just a Media component left

though the comment about it:

@mathieumg media is the worst Bootstrap part ever. It's totally broken in responsive aspect.
Not recommend.

#56 (comment)

from react-bootstrap.

It shouldn't be hard to implement, even though we know it's getting taken out of Bootstrap 4.

from react-bootstrap.

If it's getting taken out of BS4, I would just ignore it. Else we're going to end up adding it, and deprecating it in 2 months.

from react-bootstrap.

Media is not getting taken out of BS4: http://v4-alpha.getbootstrap.com/layout/media-object/

from react-bootstrap.

Guess it makes sense to add it then!

from react-bootstrap.

sadface

from react-bootstrap.

Why hasn't media been added yet? I think I'll give it a go

from react-bootstrap.

I'd appreciate that. Thanks.

from react-bootstrap.

Why is there a completely misleading "Media content" section in the docs? I think that the elements in there deserve their own sections in the nav, and that "Media content/objects" should have the actual media objects. Can I fix this as well?

from react-bootstrap.

They're for various sorts of media – carousels, responsive embeds, &c. That is the relevant category.

from react-bootstrap.

Other than the fact that it makes the documentation inconsistent with bootstrap's documentation, this leaves media objects with no section. unless I either create a new section or add them at the bottom of the Media content section, which would you suggest?

from react-bootstrap.

They should go into that top-level "media" section.

from react-bootstrap.

I suppose that means this issue is done then?

from react-bootstrap.

Thanks @alphashuro!

from react-bootstrap.