Comments (1)
I can't find any stated rationale for the associated "remove peerDependencies" commits across several related repositories. I think the correct fix is to add peer dependencies to this and related packages, instead of removing them from this package's dependencies.
Now, instead of warnings during resolution, you get errors at build or runtime:
ModuleNotFoundError: Module not found: Error: rc-animate tried to access react-dom, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Required package: react-dom (via "react-dom")
Required by: rc-animate@npm:3.1.1 (via /Users/brandonbloom/Projects/deref/.yarn/cache/rc-animate-npm-3.1.1-ebc3b6785f-bc3baf9704.zip/node_modules/rc-animate/es/AnimateChild.js)
from animate.
Related Issues (20)
- 问题:为什么transform 动画没有效果 HOT 1
- UNSAFE_componentWillReceiveProps HOT 1
- findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of AnimateChild HOT 1
- index.d.ts is not in the published package.
- react16.13.1版本,严格模式已经不支持UNSAFE_componentWillReceiveProps 和findDOMNode
- m
- Migrate docs to dumi HOT 1
- component 属性设置为 "" 时,元素消失动画失效 HOT 2
- CSSMotion 移到 2.x 里发布
- componentWillReceiveProps will be deprecated HOT 3
- 当设置了showProp时,往子节点中插入新节点,节点显示在最后
- upgrade core-js HOT 3
- CSSMotion 获取不到 HOT 1
- Cannot find module 'css-animation' HOT 2
- "licenses" field is misused in package.json
- Deprecated lifecycle method warnings with React 16.9 HOT 5
- Installing dependencies on fresh clone => `ReferenceError: primordials is not defined`
- Typescript error HOT 1
- package.json "licenses" should be "license" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from animate.