Giter VIP home page Giter VIP logo

Comments (4)

shepherdwind avatar shepherdwind commented on May 21, 2024 1

That because Panel should not be null, You can filter empty child like this

const items = [];
if (content.location) {
  items.push(<Panel />);
}

And I will fix this soon.

from collapse.

ystarlongzi avatar ystarlongzi commented on May 21, 2024 1

@afc163 好的,等下提交下

from collapse.

ystarlongzi avatar ystarlongzi commented on May 21, 2024

@shepherdwind
刚好今天也碰到这个问题,采用的方法和 @jorisw 类似,并且你推荐的方案确实可行。但在实际开发中,相信大部分开发者默认也会使用 @jorisw 这种方式吧。

感觉如果在<Collapse /> 组件内部对值为 nullundefinedfalse 的子元素过滤掉,这样应该对开发更友好吧。

还是说作者有其它设计意图?

from collapse.

afc163 avatar afc163 commented on May 21, 2024

其他组件也都优化了,可以改下:

react-component/menu#57
react-component/tabs#31

@ystarlongzi 来个 PR 如何?

from collapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.