Comments (4)
That because Panel should not be null, You can filter empty child like this
const items = [];
if (content.location) {
items.push(<Panel />);
}
And I will fix this soon.
from collapse.
@afc163 好的,等下提交下
from collapse.
@shepherdwind
刚好今天也碰到这个问题,采用的方法和 @jorisw 类似,并且你推荐的方案确实可行。但在实际开发中,相信大部分开发者默认也会使用 @jorisw 这种方式吧。
感觉如果在<Collapse />
组件内部对值为 null
、undefined
、false
的子元素过滤掉,这样应该对开发更友好吧。
还是说作者有其它设计意图?
from collapse.
其他组件也都优化了,可以改下:
react-component/menu#57
react-component/tabs#31
@ystarlongzi 来个 PR 如何?
from collapse.
Related Issues (20)
- Change header color using inline styling HOT 1
- How To Use openAnimation Property Properly HOT 2
- [A11Y] Add HTML tag "aria-hidden" HOT 1
- This style will cause me a bug
- Hide header option
- CSS not working even I import index.css following Readme HOT 1
- The lib folder is missing in the v2.1.0 package HOT 1
- 3.0.0 accordion collapse does not close HOT 1
- Is rc-motion slower?
- Mistake within the Documentation
- Migrate docs to dumi HOT 1
- [A11Y] Add "aria-disabled" attribute HOT 1
- how can i get panel header's clientHeight?
- CollapsePanel: onItemClick can not trigger HOT 1
- Is there a plan to change Class components to function components?
- Is there a plan to change Class components to function components? HOT 1
- Prop expandIcon does not have PanelProps which are mentioned on docs
- headerClass in Panel doesn`t work correctly HOT 2
- 什么**项目啊,compile直接报一大堆类型错误 HOT 1
- Panel header vertical align center
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collapse.