Cocoapods compatibility about boost-for-react-native HOT 16 CLOSED

When I set up CocoaPods for CxxBridge, boost worked out of the box for me. I never even looked at the original Podspec, so I don't know why it's set up the way it is.

My best guess why it isn't working now is that something in the maze of ifdefs changed, and now type_index.h is being included, but the type_index/ directory isn't included in any of the subspecs in the podspec you linked. Adding it to one of the existing subspecs, or making a new one, would be the next thing to try.

from boost-for-react-native.

@itchingpixels, thanks for digging the details.
Are you up to send a PR to fix that?

from boost-for-react-native.

I'd be happy to do that, but haven't got around making it work just yet - I don't know what the delta is between this and the 1.59.0 release that's on cocoapods, but it's really confusing!

from boost-for-react-native.

it seems like there's some magic (at least to me) going on with preserve_paths that I don't understand (why is it needed at all?) in the original podspec. will try a few different things and report back.

from boost-for-react-native.

@ide, do you have some context on this to help us out?

from boost-for-react-native.

I don't have a lot of context around this and @mhorowitz set up the third-party pods. If we go in this direction I think we should just add a podspec to this repo to install direct from GitHub but not publish to CocoaPods since we're not going to remember to keep it updated.

from boost-for-react-native.

Pinged @mhorowitz, thanks @ide

from boost-for-react-native.

@mhorowitz
I add a subspec to boost.podspec , then pod install again , it works.

#added by hmw
spec.subspec 'type_index-includes' do |cs|
    cs.preserve_paths = 'boost/type_index/**/*.hpp'
 end

from boost-for-react-native.

Great!!! Sorry guys that I backed out, had been super busy with a release...
@fishmwei : do you have a PR?

from boost-for-react-native.

@itchingpixels I have a PR in your branch PR

from boost-for-react-native.

Anyone wants to send a PR for this repo?
I suppose other people will have a similar problem.

Thanks @fishmwei for finding the solution.

from boost-for-react-native.

I've created a PR: facebook/react-native#16756
This is my first PR to react-native, I'm not sure what to do to get it merged in - if you can bump it, that may work?

from boost-for-react-native.

Thanks, I'll ping iOS people internally

from boost-for-react-native.

@bestander do you have any news regarding this? I'm not sure whom should I be in contact with.

from boost-for-react-native.

+1 any update ?

from boost-for-react-native.

Trunk is still broken, I'll merge it once it is green: https://circleci.com/gh/facebook/react-native/tree/master.
Someone from RN team is on it but a PR with a fix is welcome.

from boost-for-react-native.