Would love to see a Two-Marker Slider for Setting a Range about react-native-elements HOT 19 CLOSED

I think he is referring to a bidirectional related slider.
Similar to the one on Tinder or something like the one shown in the link(http://www.tutorialspark.com/jqueryUI/jQuery_UI_Slider_Bidirectional_Related_Slider.php)
I would love to have this too.

from react-native-elements.

@quadsurf Here are some sliders that I found.

1. https://github.com/jeanregisser/react-native-slider - I like that it's customizable & API looks pretty robust.
2. https://github.com/JackDanielsAndCode/react-native-multi-slider - Has implementation of multi-selection slider
3. https://github.com/franfran/react-native-snap-slider - Love the functionality that this provides

I think adding a custom slider API (like 1) + multi-selection (like 2) + snap functionality (like 3) would be good addition to the elements.

@dabit3 thoughts?

from react-native-elements.

@Monte9 I like the idea of having the customizable api of 1 and the multi selection of 2, and the snap functionality looks cool as well.

1. We can possibly add one of those existing projects as a dependency to get the component working out of the box.

2. or maybe you can even fork #1 and implement the two slider feature into a pr or something and we can still add as a dependency

3. or maybe we can copy the existing component and add out tweaks as a new component to RN Elements?

I'm cool with any of these ideas, or anything along those lines really.

from react-native-elements.

@quadsurf This sounds like a good idea. Can you shoot over a link to an example of what you had in mind, maybe implemented somewhere else? Thanks

from react-native-elements.

Update: Slider has been added to the latest release of RNE. Check out the documentation here.

We went with Option 1. I'll leave this issue open as it would be cool to add on Option 2 & Option 3 to the existing Slider component.

If anyone has bandwidth and would like to submit a PR to enhance it, I am open to merging it.

from react-native-elements.

In an effort to streamline all RNE issues such that it is easier to get to solutions faster/ submit a new issue we have decided to close any enhancement/roadmap features as "issues".

Feel free to use this issue to talk about this feature and ping @binoy14 or me (@Monte9) if you feel like you can submit a PR for this. Thanks in advance.

Also you can track the status of this feature and all other roadmap features here.

from react-native-elements.

Would love to see 2 sliders as well :)

I see this is a fork of jeanregisser/react-native-slider#142 so this PR does just that.

What do ya'll think?

from react-native-elements.

@flyingcircle I am interested in developing this,

from react-native-elements.

@mt81 go for it.

from react-native-elements.

@flyingcircle Apologies for the duplicate ticket, but the idea is still worth implementing right? I've read all the closed PRs and issues on this thread, and I think I can work on implementing the Slider ideas 2 and 3. Is it alright if I start working on adding them to the library and then to the app?

from react-native-elements.

I would like to work on it as well. @flyingcircle

from react-native-elements.

Working on this

from react-native-elements.

Hey, I have already started working on this one. I'm actually planning to add it to RNEU after approval. Do check out other issues.

from react-native-elements.

@HariAcidReign What is your approach!? I also started ! Its been 5 days so I thought you started doing some other issues!?

from react-native-elements.

I had described it in the above issue in RNEU. They haven't given the go-ahead yet, but I had started to implement it anyway. So hopefully by this weekend, I should be done with half of my proposed issues. And the rest will be done (implementation+tests) by next weekend. 👍🏻

from react-native-elements.

@HariAcidReign Sure no problem go ahed. Goodluck!

from react-native-elements.

@HariAcidReign This component will probably require tests! If you are not writing tests I can do that if you can let me know few implementation details!? Or you have also started writing tests!?

from react-native-elements.

Haven't started testing yet. If I get any hiccups, I'll let you know for sure 🎉

from react-native-elements.

Closing this in favor of this discussion

from react-native-elements.