Comments (13)
tienviip
commented on May 17, 2024
hi @ThomasLarge have you found a solution for videocall, please support me.
from react-native-callkeep.
ThomasLarge
commented on May 17, 2024
@tienviip do you mean how to get it working? or the issue I have above?
from react-native-callkeep.
tienviip
commented on May 17, 2024
@ThomasLarge yep, I also encountered your problem above, Can you help me, please.
from react-native-callkeep.
ThomasLarge
commented on May 17, 2024
@tienviip I'm waiting on someone to help me too 😆 I'm going to try and dig into it later but haven't got the time at the moment that's why I have opened the issue
from react-native-callkeep.
LinusU
commented on May 17, 2024
The problem is probably that hasVideo is hard-coded to NO here:
from react-native-callkeep.
ThomasLarge
commented on May 17, 2024
@LinusU Looks like it's here too
Do you think it's best to change the file locally or is it best to wait until the repo has been updated?
from react-native-callkeep.
danjenkins
commented on May 17, 2024
Update it locally, see if it fixes your issue and then submit a PR with it
configurable :) in all likelihood it won't get fixed unless you fix it!
…On Wed, 26 Jun 2019, 13:12 Thomas Large, ***@***.***> wrote:
@LinusU <https://github.com/LinusU> Looks like it's here too
https://github.com/react-native-webrtc/react-native-callkeep/blob/7d7306027834da68f488b4d88bb1ad9910e9348b/ios/RNCallKeep/RNCallKeep.m#L254
Do you think it's best to change the file locally or is it best to wait
until the repo has been updated?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#54?email_source=notifications&email_token=AAB3LLJSYIJU4YKKPAONIY3P4NMKDA5CNFSM4HRYEMK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYTKC6Y#issuecomment-505848187>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB3LLOKBIEFQNETMYIKQK3P4NMKDANCNFSM4HRYEMKQ>
.
from react-native-callkeep.
ThomasLarge
commented on May 17, 2024
@danjenkins & @LinusU I have changed that file and it doesn't seem to work still I think there's more places it's hardcoded or it's something that isn't working in the package. I haven't got the time over the next couple of days to look into it more but I will over the weekend. There's also these two lines
react-native-callkeep/index.js
Line 48 in 5cae457
react-native-callkeep/index.js
Line 57 in 5cae457
from react-native-callkeep.
jaswantjatav
commented on May 17, 2024
HI anyone found a solution for showing incoming call ui, please help me, I am using react-native-WebRTC plugin , react-native-callkeep and want to show incoming call ui but nothing showing even I called the function
RNCallKeep.displayIncomingCall("978697869", "TESting");
But no luck, please help me if anyone got solution.
from react-native-callkeep.
danjenkins
commented on May 17, 2024
@jaswantjatav if you need help then please make a new issue
from react-native-callkeep.
danjenkins
commented on May 17, 2024
So you need to change
'sNO to hasVideo
I'd just comment out the line
@ThomasLarge those 2 links to the index.js are just setting a default of false. If you pass in true it'll be true :)
Make sure you close down your metro packager etc etc and build from scratch with the change done locally in your node_modules directory if you want to test it out :)
from react-native-callkeep.
ThomasLarge
commented on May 17, 2024
Cheers @danjenkins I will look at this tomorrow or the weekend
from react-native-callkeep.
ThomasLarge
commented on May 17, 2024
I can confirm this is all fixed 👍
from react-native-callkeep.
Related Issues (20)
- getAudioRoutes definition returns Promise<void>, but should return Promise<AudioRoute[]>
- No calling UI when receiving a call on iOS 17.1.1 HOT 3
- How to backToForeground IOS
- [iOS] Declining Incoming Call to SIM number triggers `endCall` event HOT 14
- Call not ending on remote device if call was declined too fast on iOS HOT 3
- call keep crash : index 0 beyond bounds for empty array HOT 4
- Is there a way to specify the ringtone on Android?
- PhoneAccount Connection service requires BIND_TELECOM_CONNECTION_SERVICE permission HOT 1
- The Speaker icon is removed, while switching the route from Bluetooth or Microphone to Speaker from the call kit screen. HOT 1
- [TypeError: Cannot read property 'setup' of null] when call setup HOT 1
- hasPhoneAccount() returns true in self managed mode, without checking if the device supports it
- [iOS] hold/unhold issue HOT 4
- Permission to Use Android's Telecom Connection Service Denied
- I cannot hear anything including ringtones when I start calling on Android. HOT 2
- IOS: Receiving Call issue HOT 3
- callActive
- Call merge/conference Android (Self-Managed) and iOS
- I cannot hear anything when I start calling with Agora HOT 2
- How to manage SIM call?
- After phone restart, Incoming call doesn't get triggered on IOS.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-callkeep.