Typescript definitions about redux-helpers HOT 12 CLOSED

@Ashoat What inactivity do you mean? What do you think about the code above? What if I write a PR providing this code in .d.ts file?

from redux-helpers.

@rodrigoelp Could you please take a look at my PR (#17)? I have slightly changed your code (mostly added exports from other files). Feel free to review it!

from redux-helpers.

Keeping the types within the repo is what I do with Flow, even though we use flow-typed for the mainline react-navigation package. I'll defer to you on where to place it for TypeScript. PRs are welcome! :)

from redux-helpers.

For helping you, the typescript definition is :

declare module 'react-navigation-redux-helpers' {
    import { NavigationState } from 'react-navigation';
    import { Middleware } from 'redux';

    export function createReactNavigationReduxMiddleware<S>
        (key: string, navStateSelector: (state: S) => NavigationState): Middleware;

    export function createReduxBoundAddListener(key: string): void;
}

from redux-helpers.

Closing due to inactivity

from redux-helpers.

PR definitely welcome! We have a couple new exports now (four in total), so any libdef would need to cover all four.

from redux-helpers.

Just to add to the "activity" part. 👍 to @vdelacou for providing the type definition or whoever producing the PR and I don't want to steal somebody else's thunder.

What are you going to do then? I will vote to keep the type definition within the project as opposed to DefinitelyTyped.

from redux-helpers.

By the way, just noticed the type provided is wrong as it does not allow me to create a listener... so I have fixed it here:

declare module 'react-navigation-redux-helpers' {
    import { NavigationState, NavigationEventCallback, NavigationEventSubscription } from 'react-navigation';
    import { Middleware } from 'redux';

    // This was the part that was missing.
    type Listener = (eventName: string, callback: NavigationEventCallback) => NavigationEventSubscription;
  
    export function createReactNavigationReduxMiddleware<S>
        (key: string, navStateSelector: (state: S) => NavigationState): Middleware;
  
    // So, createReduxBoundAddListener can match the signagure expected
    // when creating a 'navigation' object.
    export function createReduxBoundAddListener(key: string): Listener;
}

from redux-helpers.

Hosting in-package is great! PR welcome :)

from redux-helpers.

I know @Ashoat, I do want to give the opportunity to @vdelacou as he was the one posted the original declaration. If nothing happens in two or three days, then I will create the PR and send it

from redux-helpers.

Thanks @vyshkant for putting up a PR!! @vyshkant has listed a couple questions on his PR, but I'm not very familiar with TypeScript, so would be great if anybody else on this thread who is familiar could join the discussion on that PR.

from redux-helpers.

Will continue the convo in the PR.

from redux-helpers.