Giter VIP home page Giter VIP logo

Comments (3)

FateRiddle avatar FateRiddle commented on July 22, 2024 2

@satya164 Thanks for the solution, but the usage is still not obvious for most users.
Also when I tried it out, I find you may need to change the code:

 line =>`<span class="container_editor_line_number">${line}</span>`

to

 line =>`<span class="container_editor_line_number"><span>${index+1}</span><span>${line}</span></span>`

And even after this, the styling can be tricky, because if the code line wraps, it won't leave the white space for line number and just starting from very left.

Also selection of code will work weirdly as if the code is still in its original place without the addition of line numbers (at least that happens to my code)

I'd be appreciated if you could just add that functionality as props.

from react-simple-code-editor.

satya164 avatar satya164 commented on July 22, 2024 1

You can do it in your code: 809d5f0

from react-simple-code-editor.

satya164 avatar satya164 commented on July 22, 2024

this solution highly depends on how you perform syntax highlighting etc. I can't add it in core because we don't control the HTML generated after syntax highlighting.

from react-simple-code-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.