Ability to set the textarea id attribute about react-simple-code-editor HOT 8 CLOSED

@davidjamesstone Okies! I sent a PR adding a prop for that. Lemme know if it works for you.

from react-simple-code-editor.

Another nice to have prop is placeholder. The textarea element has it built-in but I can't seen to be able to set it though simple code editor.

from react-simple-code-editor.

@davidjamesstone maybe you could do this instead:

<label>
  This is some label
  <Editor />
</label>

IMO IDs don't play very well with component-based designs because they need to be unique.

@oliveiraddb can you send a PR adding the prop? note that you'll also need to add the following CSS for the placeholder to showup.

.editor textarea:empty {
  -webkit-text-fill-color: initial !important;
}

from react-simple-code-editor.

@satya164 Implicit labels wont work in my case as they break the css/layout which I have no control over. They also aren't as well supported as explicit labels in assistive / accessible tooling.

I agree about IDs being kind of at odds with component based design but I don't have an alternative here.

from react-simple-code-editor.

Looks good & Thank you!

from react-simple-code-editor.

See #13 and #14 around how we'd like to avoid preventing more customisation in the future :) It's becoming apparent that every time someone discovers some smaller prop issues or sth they need to customise, they hit a wall and need a fix in the main lib, so customisability would be a neater answer ✨

from react-simple-code-editor.

Thanks @satya164. Much appreciated.

from react-simple-code-editor.

Actually this prop isn't released. I just added placeholder prop. Will support id with render props later.

from react-simple-code-editor.