Provide app configuration based on --env value about react-webpack-template HOT 6 CLOSED

Added an implementation for this feature in f7c211a. To avoid interfering with the NODE_ENV variable it sticks REACT_WEBPACK_ENV to process.env (here). Added a test case that checks for the value of config.appEnv in src/config/test.js.

@weblogixx maybe you could take a short look and check if you think it looks okay.

from react-webpack-template.

@sthzg: Thanks for the work, it is really appreciated. I will have a look at it and give you feedback until the end of the week.

from react-webpack-template.

I just reviewed it and think that this one is really really nice. Thank you for this! If you would adjust the README to reflect the new feature, I will happily merge it. Don`t forget to add yourself to contributors entry :).

_Update_:
Please also provide a small README.md in the new src/config folder that shows how it can be included. Just like src/actions for example.

from react-webpack-template.

Sorry(!) for the noise in the commits. I had troubles rebasing the feature, but the last commit is now correctly squashed to one commit and updated with the current upstream. If the changes to the README are okay I would make it a PR.

from react-webpack-template.

Thats not a problem (I made lots of such "noisy" commits myself). Looks good to me. Looking forward to the PR 👍 :).

from react-webpack-template.

Just merged it. Thanks for the good work :)

from react-webpack-template.