Comments (6)
Added an implementation for this feature in f7c211a. To avoid interfering with the NODE_ENV
variable it sticks REACT_WEBPACK_ENV
to process.env
(here). Added a test case that checks for the value of config.appEnv
in src/config/test.js
.
@weblogixx maybe you could take a short look and check if you think it looks okay.
from react-webpack-template.
@sthzg: Thanks for the work, it is really appreciated. I will have a look at it and give you feedback until the end of the week.
from react-webpack-template.
I just reviewed it and think that this one is really really nice. Thank you for this! If you would adjust the README to reflect the new feature, I will happily merge it. Don`t forget to add yourself to contributors entry :).
_Update_:
Please also provide a small README.md in the new src/config
folder that shows how it can be included. Just like src/actions
for example.
from react-webpack-template.
Sorry(!) for the noise in the commits. I had troubles rebasing the feature, but the last commit is now correctly squashed to one commit and updated with the current upstream. If the changes to the README are okay I would make it a PR.
from react-webpack-template.
Thats not a problem (I made lots of such "noisy" commits myself). Looks good to me. Looking forward to the PR 👍 :).
from react-webpack-template.
Just merged it. Thanks for the good work :)
from react-webpack-template.
Related Issues (20)
- V1 -- Remove --open call on npm start HOT 3
- V2 -- Refactor index.html to be template-driven HOT 8
- V2 -- Update tests to use inline functions HOT 1
- V1 -- Refactor tests to use inline function HOT 1
- V2 -- Add static directory to build step HOT 1
- Update README in src/config dir HOT 1
- V2 -- Update coverage information
- V2 -- Update copying static files to copy-webpack-plugin
- V2 -- Fix eslint rule deprecation warning
- V2 -- serve:dist does not load page HOT 1
- V2 -- Update deprecated es2015-native-modules preset HOT 1
- V2 -- Upgrading to react-hot-loader v3? HOT 2
- V2 -- Centralize defaultPort setting HOT 5
- Module build failed: Error: Couldn't find preset "es2015" HOT 1
- V2 -- Divide env config into appEnv and nodeEnv HOT 1
- V1 -- Add temporary fix for `ReactMount` bug HOT 1
- V2 -- Redundant entry in webpack Base HOT 1
- V2 -- HMR - named Modules
- V2 -- Webpack - NoErrorsPlugin is deprecated
- Is there an easy way to add Express to this webpack-config-template for 'dist'?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-webpack-template.