Comments (5)
Another item for the Next 10 part of the upgrade is to move the viewport
meta into _app
from _document
as there's an issue in Next deduplicating at least that one meta tag (and later Next versions will WARN about it). See here for more info: vercel/next.js#13230
from example-storefront.
Using Next 10 would help reduce quite some boilerplate related to i18n. We wouldn’t need the toplevel dynamic path segment anymore, also Links don’t need to specify as and href each time as Nextjs would resolve them automatically. Browser Header locale detection is now built in aswell.
from example-storefront.
Another easy win is to upgrade react-helmet to 6.x to clean up some particularly noisy Next compiler warnings.
from example-storefront.
@balibebas In other projects I removed react-helmet
altogether in the meantime as next/head
provides the same functionality that was used from helmet. Especially since the head and managing the order in there etc. seems to be an ongoing thing where issues seem to pop up here and there and further recent changes where made in nextjs, I'd be in favor of keeping this simple.
from example-storefront.
Also going to suggest a bump to MUI v5 beta as, according to maintainers, V4 has been out of active development for a year.
from example-storefront.
Related Issues (20)
- Add pre-commit hooks for linting commit message
- Can't complete order with products from multiple stores
- Checkout is broken in production mode
- Stripe instructions not working. HOT 3
- Login button on Checkout not working HOT 1
- update package-link and unlink HOT 1
- Cannot check out when only Example IOU method is enabled
- Unable to navigate in EntryModal by keyboard
- SPIKE: Investigate paths forward for NextJS Storefront project HOT 3
- Payment methods does not available HOT 3
- Select a Store Pickup Location while in Checkout
- Estimated time of order ready for pickup at Location
- Store Pickup Storefront
- Select a Store Pickup Location when adding an item to cart
- Select Store Pickup when adding an item to cart
- Browse PLPs based on availability at a Location
- Favorite a Store Pickup Location
- Set a Store Pickup Location while Browsing
- Store Pickup in Storefront
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from example-storefront.