Comments (7)
I just added #88 to the 1.0 milestone because #22 was in there. I think those are the last things that we need to resolve.
from reactiveswift.
We probably need an extension like this:
extension Date {
internal func addingDispatchTimeInterval(_ interval: DispatchTimeInterval) -> Date {
switch interval {
case let .seconds(s): ...
case let .milliseconds(ms): ...
...
}
}
}
from reactiveswift.
We probably need an extension like this:
Should we not instead remove the use of Date
entirely in favour of DispatchTime
? I never did like using {NS,}Date
to represent a point in timeβ¦
The usage gets much nicer, too. Compare using Date().addingDispatchTimeInterval(.milliseconds(300))
vs. .now() + .milliseconds(300)
, for example.
from reactiveswift.
Yup π
from reactiveswift.
I've gone ahead and done much of the work already here for a whole-hog replacement of Date
and TimeInterval
: master...liscio:cl-dispatchwalltime
Unfortunately, it appears that DispatchWallTime
(and DispatchTime
, but we don't want to base our scheduler on that) is busted in the Swift standard library. I filed a bug (SR-2807) to track the issues I encountered. Specifically, the crash when comparing two DispatchWallTime
s is going to block progress.
from reactiveswift.
I've also gone ahead and opened #48 with the approach that was originally proposed, since it's not practical to expect the above issue to get corrected in time for 1.0.
from reactiveswift.
It looks like this was fixed by #48 (good job!). Is the 1.0 milestone up to date? This is the only open issue left in it at the moment.
from reactiveswift.
Related Issues (20)
- Release 6.6.0 requires Swift 5.3 and therefore Xcode 12.x
- Using "<~" binding function with Signal.Observers causes memory leaks. HOT 3
- Using old xcconfig causing problems with Carthage & Apple Silicon macOS builds
- Support await / AsyncSequence HOT 13
- Playground does not work HOT 1
- Hello, ask a question about Disposable, thanks HOT 1
- What's means 'targeting' in QueueScheduler? HOT 2
- Signal.merge reported issue after migrating from ReactiveSwift from 4.0.0 -> 6.6.0 HOT 2
- xCode13 CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
- Usage with SwiftUI HOT 4
- Could not find module 'ReactiveSwift' for target 'arm64-apple-ios-simulator' HOT 2
- [BUG] XCode 14 beta 3 - bitcode issue HOT 1
- Is it planned to add count argument to `collect(every:on:skipEmpty:discardWhenCompleted:)`?
- Adopt OSAllocatedUnfairLock on iOS 16 HOT 9
- Add support for mapping Property/MutableProperty types to a Binding
- Signal triggered by phone call when device is closed HOT 3
- Infinite recursion in observeSwitchToLatest() HOT 3
- EXC_BAD_ACCESS Crashes occur in xcode15 HOT 4
- Reactive Swift crash with getCache function and observeSwitchToLatest signal
- Is there any plan for future releases? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactiveswift.