OAuth2 flow about refit HOT 7 CLOSED

@alexandru-calinoiu shouldn't that be called spaghetti auth?

from refit.

This is an interesting case that isn't really handled well by Refit at the moment - i.e. you effectively want "automatic error handling" for certain types of errors. Right now, I'd probably try to create a wrapper class around the interface that did the OAuth token refresh dance, but that's a lot of manual typing (i.e. exactly the stuff that Refit tries to eliminate).

Once 2.0 is released, one thing you can do is to edit the template that the shim classes are generated from, which would make it easier to add this custom behavior

from refit.

@paulduran Thanks for the tip, any estimate on the release of refit 2.0?

from refit.

@Balauru It's currently blocked on Xamarin.iOS bugs, check out #38

from refit.

Will you consider releasing a beta nuget package with 2.0beta.

It will help me (and probably some other people) integrate the new version and help stabilizing it.

from refit.

No, because it doesn't work correctly at the moment :) There's still some dumb bugs around Visual Studio (VS decides to not define $ProjectDir inexplicably in certain projects, which breaks everything).

That PR basically has resulted in me finding every MSBuild / xbuild bug ever, and I have to work around them all in order to ship something that will work

from refit.

With the help of #41

I can do something like this:

private IObservable<T> Authorize<T>(IObservable<T> observable)
        {
            return Observable.Create<T>(
                observer =>
                    {
                        observable.Subscribe(
                            // OnNext
                            observer.OnNext,
                            // OnError
                            e =>
                                {
                                    if (IsUnauthorized(e))
                                    {
                                        _oAuth2.Refresh(_token.refresh_token)
                                            .Concat((IObservable<object>)observable)
                                            .Where(o => o is T)
                                            .Cast<T>()
                                            .Subscribe(observer);
                                    }
                                    else
                                    {
                                        observer.OnError(e);
                                    }
                                },
                            // OnComplete
                            observer.OnCompleted);

                        return Disposable.Create(() => { });
                    });
        }

Basically wrapping the initial observable into a new one that deals with the authorization if the case might be.

from refit.