Giter VIP home page Giter VIP logo

Comments (2)

rotexhawk avatar rotexhawk commented on May 25, 2024

Yes there seems to be a bug in exercise 20. It passes if you run it in the website but if you run it externally it will give you an error where that last .map() is.

from learnrx.

seanpoulter avatar seanpoulter commented on May 25, 2024

CC: You can probably close this as a duplicate of #44 @morenoh149.


Good catch! It seems like a bug if you run reduce(...).map outside of the site but this is actually intentional. In Exercise 16 we write our own implementation of Array.prototype.reduce that returns the result in an Array. It has this little note:

Let's add a reduce() function to the Array type. Like map. Take note this is different from the reduce in ES5, which returns a value instead of an Array!

I found it confusing too. This was an intentional design choice that is discussed in #44. I'd summarize #44 by saying "we" decided to use the modified version of Array.prototype.reduce that returns an Array because it is similar to Observable.prototype.reduce returning an Observable. It's "more clear" to chain calls like reduce().map then it is to explain why the result types are different. (Personally I disagree with this approach. It'd be straightforward to explain we need to return an Array so we can chain the calls. 🤷‍♂️ )

from learnrx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.