-Werror for unsafe nullptr - `decltype((*(input_type*)nullptr).out((*(Subscriber*)nullptr)))' evaluation about rxcpp HOT 3 CLOSED

Am willing to get this working and to provide a PR (with guidance). I thus gave it a quick shot -- ignoring the warnings aside (for which the code works perfectly well -- I replace the offending pointer-casting-magic in the above and other similar locations by

using type = decltype(std::declval<input_type>().in(std::declval<Observable>()));

On that note, I am having two questions:

1. what is the C++ standard that this library aims for?
   The README.md seems to indicate C++20 ([..] RxCpp depends on the latest compiler releases [..])
2. why these type declarations? Wouldn't automatic type deduction (auto) or constraint types via concepts work equally?
   This would make the code easier to read/reason from a C++20 perspective and provide nicer compiler errors, wouldn't it?

Any feedback on this would be appreciated.

from rxcpp.

@kirkshoop or anybody else: any chance to get feedback on this and the corresponding PR?

We liked to use it in our C++20 project but the compiler warnings turned into errors would be a substantial technical burden.

Thanks in advance and much appreciated! 👍

from rxcpp.

@kirkshoop thanks for merging and accepting this! Issue is fixed by PR closing now.

from rxcpp.