Giter VIP home page Giter VIP logo

Comments (3)

kzaher avatar kzaher commented on May 22, 2024

It's funny, but I've written unit test about that case yesterday.

func testObserveWeak_ObserveCGRect() {
        var root: HasStrongProperty! = HasStrongProperty()

        let latest = RxMutableBox<CGRect?>(nil)

        XCTAssertTrue(latest.value == nil)

        root.rx_observeWeakly("frame")
            >- subscribeNext { (n: NSValue?) in
                if let n = n {
                    var frameValue = CGRect(x: 0, y: 0, width: 0, height: 0)
                    n.getValue(&frameValue)
                    latest.value = frameValue
                }
                else {
                    latest.value = nil
                }
            }
     ...

CGRect becomes in KVO world NSValue, and it's not CGRect, so that's why it's nil.

Having said that, I think I can actually improve this and internally unwrap CGRect and CGPoint so it should work when you do

nibView.rx_observe("bounds") as Observable<CGRect?>
        obs >- subscribeNext { bounds in
            println(bounds)
        }

Just didn't came to my attention :)

Let me know does that work.

I think I know a way to improve this for next release, but I will need to investigate more.

from rxswift.

kzaher avatar kzaher commented on May 22, 2024

Also, be careful, I think UIView classes aren't officially KVO compliant, but on the other hand, I doubt Apple will ever make them not compliant :p

from rxswift.

kzaher avatar kzaher commented on May 22, 2024

I've added official support for observing CGRect, CGSize and CGPoint. There are specializations that handle those cases.

It's even documented now :)

https://github.com/kzaher/RxSwift/blob/master/Documentation/GettingStarted.md#observing-structs

Closing this issue, let me know if you have any further problems.

from rxswift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.