Unsubscribing and timer about rxswift HOT 6 CLOSED

By the way, I'm using this gist for the timer: https://gist.github.com/natecook1000/b0285b518576b22c4dc8

from rxswift.

Hi,
wow :) It's a bug. Thnx for creating an issue.

So AutoDetach observer was in place and it was disposing in case of sequence was completed, but in case you didn't dispose producer, it would pass events until producer was disposed.

Problem was here

override public func subscribe<O : ObserverType where O.Element == Element>(observer: O) -> Disposable {
        let autoDetachObserver = AutoDetachObserver(observer: observer)

        let disposable = subscribeCore(ObserverOf(autoDetachObserver))
        autoDetachObserver.setDisposable(disposable)

        return autoDetachObserver //<< was disposable 
    }

I can fix this, add additional unit tests and push this to develop branch.

This doesn't seem to me like a critical issue, so are you ok just using develop branch code until next release until this enters master branch?

from rxswift.

Hi, thanks for the fast response.

It's ok, I'm just learning, so I'm not in a hurry. It just helps to know it wasn't me doing something wrong. I'll keep an eye on the fix to see if I can understand what was going on :)

from rxswift.

I think I am experiencing this bug, too... but with throttle.

from rxswift.

The fix should be in develop

commit 24dc2c6
Author: Krunoslav Zaher [email protected]
Date: Fri Jul 24 16:47:49 2015 +0200

Fixes problem with issues/67.

@alcarvalho send me all heisenbugs 😛

from rxswift.

These changes have been released in the latest release. Closing this issue. Let me know if it happens again.

from rxswift.