Giter VIP home page Giter VIP logo

Comments (5)

koba04 avatar koba04 commented on May 4, 2024 2

I've enabled the setting so now passing CircleCI check is required to merge PRs.

I know nothing about the official deploying process, but setting up an independent test site on Netlify does not "pollute" the codebase and has no side effects, right?

Yes, I assume that it only has to create settings on Netlify, which doesn't affect the codebase.
I'll work on that.

from ja.reactjs.org.

koba04 avatar koba04 commented on May 4, 2024 1

@gaearon I’d like to add deploy previews for each PRs using Netlify. reacts/reactjs.org provides the feature using reacts-bot.
Can we use the bot as well?
Should we configure the setting ourselves?

https://github.com/reactjs-bot

from ja.reactjs.org.

koba04 avatar koba04 commented on May 4, 2024 1

Netlify integration has been enabled so I close this.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

CI for PRs is working very well, so I think requiring the green status is fine.

I know nothing about the official deploying process, but setting up an independent test site on Netlify does not "pollute" the codebase and has no side effects, right?

from ja.reactjs.org.

koba04 avatar koba04 commented on May 4, 2024

@tesseralis 👆 What about this?

from ja.reactjs.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.