Giter VIP home page Giter VIP logo

Comments (128)

smikitky avatar smikitky commented on May 4, 2024 6

⚠️ 各位、特に現在進行中の翻訳ブランチ・PRをお持ちの方 (@uenitty @Naturalclar @sato11 @locol23 @atsumine @takanorip @superyusuke @uehaj @lightnet328):

reactjs/react.dev#1608 と、それに対応する #96 の作業が完了し、すべての見出しに明示的にアンカー名が入るようになりました。以下のようなシンタックスです。これにより、ページ間・ページ内のすべてのリンクがURLを全く変えずに動作するようになります。

## Try React {#try-react}

### What does const [thing, setThing] = useState() mean? {#destructuring}

翻訳する時は、アンカー部分はそのまま残して、見出し本文のみを翻訳してください。

## React を試す {#try-react}

### const [thing, setThing] = useState() という記法の意味は? {#destructuring}

まだ master にマージされていない PR をお持ちの方は、ちょっとしたコンフリクト解決作業をお願いします。大きな改変なので、ブランチの rebase と force-push による作業がお勧めです。殆どの方には釈迦に説法で申し訳ありませんが、こちらでも軽く説明しています。お手数ですがよろしくお願いします。

本日朝時点までにマージ済みの翻訳については、既にアンカーが付いていますので特段の作業は不要です。

これで無事 v16.8 リリース(Hook 導入)と ID 導入という大きな作業を乗り越えたので、当面は大きな改変はそうそう起きないと思います。よろしくお願いします。

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 5

お知らせ 半角スペースにまつわる細かいルールについてお手数をおかけしていましたが、自動でこれらを発見できる(--fix による自動修正はまだできない) textlint を #98 で導入しました。リベースして取り込んでいただければ作業が少し楽になると思います。よろしくお願いします。

from ja.reactjs.org.

lightnet328 avatar lightnet328 commented on May 4, 2024 4

May I take React and React.Component?

from ja.reactjs.org.

takanorip avatar takanorip commented on May 4, 2024 4

I have some questions.

  1. Why we should check the old translation? I think it is too old.
  2. How do we check the quality of the new translation? How is the reviewer determined?

If I shouldn't discuss here, change the place.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 4

@y-temp4 @atsumine @uenitty @locol23 Thank you, please start translations.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 3

@ossan-engineer Sorry for the late reply. よろしくお願いします.
@superyusuke Thank you. ホームページとなると一段厳しくみんなでクオリティチェックされる可能性が高いのでレビューは気長にお付き合いください。
@queq1890 Yes, thank you!

from ja.reactjs.org.

uehaj avatar uehaj commented on May 4, 2024 3

I'm thrilled to see what's going on here and I'd really like to lend a hand.
Just wondered: @uehaj are you taking the whole Warnings section? If it's too much work to be done during this weekend, tell me so I can be of help.

Sorry for late responding and thanks for consideration. I have done whole warnings section.
Textlint is passes the last PR commit.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 3

主にレビューでご協力くださっている方へ:

「今からレビューをするぞ」というところで、そのように個別のPRページ上で宣言していただくようお願いします。レビューはとても大切ですが、2人が全く同時にレビューすると「同じ指摘が重複して単純に労力の無駄」「コメント量が約2倍になって見づらい」「万一指摘が矛盾していたときに面倒」といったことになりがちですので、まずは1名が宣言した上で全体のレビューをしっかりやるのが効率的だと思います。その分少しだけレビュープロセスが長くなる可能性がありますがご了承ください。

CC @koba04 @potato4d @takanorip @sasurau4

(とはいえこんな心配しないといけないのはとても有り難いです)

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 2

@takanorip @superyusuke Thank you for your interest.

  1. It depends on the article you're referring to. Some pages are already nearly 100% complete on Crowdin. In addition, the translation there are more or less reviewed with consistency in mind by more than one person, so it's safer to start based on it whenever possible. Still, you can always ignore some (or all) of them if you want.
  2. This fork started yesterday, and there is no established workflow yet. Tentatively, @tesseralis assigned me as the primary reviewer/maintainer, and I am willing to check every PR. I was also the person who once completed the translation at Crowdin. Honestly speaking, I did not expect this enthusiasm, so someone who wants to focus on quality assurance can nominate themselves as a dedicated reviewer.

My top priority is to make a translation guide (including style guideline).

from ja.reactjs.org.

kn3ny avatar kn3ny commented on May 4, 2024 2

Can I take DOM Elements?

from ja.reactjs.org.

takanorip avatar takanorip commented on May 4, 2024 2

@smikitky
Thanks for your answer.
I translate some documents and review other translation for now.

I will translate Test Utilities.

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024 2

I'd like to work on Installation (getting-started.md)

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024 2

Hi everyone!

I'm simply amazed at the incredible effort you've put in so far. I updated the issue with a stronger guideline on the rest of the sections, as suggested by @gaearon.

@ossan-engineer, the FAQ is composed of multiple sections. Could you start off with one and open up the rest to other people?

from ja.reactjs.org.

ytorii avatar ytorii commented on May 4, 2024 2

素晴らしい。
一昨年のCrowdInでは作業者が数人しか居なかったけど、今回はこんなにContributeする方々が居るとは!

@smikitky
自分もまた時間作って翻訳に参加させて頂きます。

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024 1

@smikitky I think I'll be able to handle the bot myself -- we'll probably end up forking che-tsumi so it'll be easier to customize. @potato4d I would still like your help though -- I'll ask you some questions in email :)

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

For now,

  • Please do NOT modify link URLs in the original markdown even if there is a Japanese equivalent (using the Japanese version of an MDN/Wikipedia article, etc)
  • Please do NOT worry about anchor names, just translate the heading text (reactjs/react.dev#1608). This means some inter-page links won't work now, but we'll fix this afterwards.

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024 1

@potato4d do you have any thoughts from your experience with vue?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

Okay, I'll take care of the tutorial.

from ja.reactjs.org.

Nkzn avatar Nkzn commented on May 4, 2024 1

May I take Thinking in React ?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

@Nkzn Yes, please!

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024 1

@lightnet328
Yes, please!
thanks!

from ja.reactjs.org.

ossan-engineer avatar ossan-engineer commented on May 4, 2024 1

Can I take FAQ ?

from ja.reactjs.org.

saitolume avatar saitolume commented on May 4, 2024 1

Could I take JS Environment Requirements ?

from ja.reactjs.org.

sakit0 avatar sakit0 commented on May 4, 2024 1

I'd like to work on Shallow Renderer

from ja.reactjs.org.

queq1890 avatar queq1890 commented on May 4, 2024 1

May I work on Test Renderer?

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024 1

@takanorip @superyusuke
(As additional information) see #2 and #6 and #3
If you have an opinion, please comment!

from ja.reactjs.org.

gotchane avatar gotchane commented on May 4, 2024 1

May I work on ReactDOM?

from ja.reactjs.org.

euxn23 avatar euxn23 commented on May 4, 2024 1

May I work on ReactDOMServer?

from ja.reactjs.org.

watilde avatar watilde commented on May 4, 2024 1

Contributing seems to be done p much already on crowdin.

from ja.reactjs.org.

summertree128 avatar summertree128 commented on May 4, 2024 1

May I work on SyntheticEvent ?

from ja.reactjs.org.

kik4 avatar kik4 commented on May 4, 2024 1

May I take CDN Links and Create a New React App ? (CDN Links is too short and is already finished.)

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

Added the list of Advanced Guide / Contributing articles you can work on this weekend :)


@sato11 Thank you, assigned you to add-react-to-a-website. Each page under warnings are relatively small, so one person might handle that.

from ja.reactjs.org.

fsubal avatar fsubal commented on May 4, 2024 1

May I take Portals in Advanced guides ?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

@fsubal 渋いチョイスですねw よろしくお願いします

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

@shooontan Yes, thank you!

from ja.reactjs.org.

ginpei avatar ginpei commented on May 4, 2024 1

Hi I'd love to join. Can I take React Without ES6 in Advanced Guides?

from ja.reactjs.org.

ossan-engineer avatar ossan-engineer commented on May 4, 2024 1

Hi, can I take Render Props ?

from ja.reactjs.org.

hassi32 avatar hassi32 commented on May 4, 2024 1

Hi, can I take React Without JSX in Advance Guides?

from ja.reactjs.org.

uehaj avatar uehaj commented on May 4, 2024 1

May I take "Optimizing Performance" ?

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024 1

@smikitky
方針に賛成です。

一方で、一人だけでは気づかないこともあるはずなので、せっかく今 2 Appove がマージ条件になっていることも活かして、 Approve を出したタイミングで別の人が見るという流れを基本とすると効率的かなぁと思いますが、いかがでしょう?

つまりは以下のフローとなります。

  1. レビュアー A レビュー宣言
  2. レビュアー A レビュー
  3. 作業者 レビュー対応
  4. (2〜3を繰り返し) レビュアー A Approve
  5. 1〜4をレビュアー B が行う
  6. マージ

from ja.reactjs.org.

koba04 avatar koba04 commented on May 4, 2024 1

レビュー中か示すのは、コメントだと見落としが発生しそうなので、ラベルをつける運用でどうでしょうか?
「in review」というラベルを作ってみました。
レビュー開始時に付与して、レビューが終わった(Approveした)ら外す形で。

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024 1

Could I take dont-call-proptypes in the Warnings section?

Edit
Actually, I saw that dont-call-proptypes is already being reviewed in #50.

Could I take Typechecking With PropTypes instead?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

@Sasurau Hooks-related articles have been already translated, so could you choose another article?

from ja.reactjs.org.

sasurau4 avatar sasurau4 commented on May 4, 2024 1

@smikitky Oh, I misunderstood! 💦
I take Accessibility instead.

from ja.reactjs.org.

notherno avatar notherno commented on May 4, 2024 1

Hello, could I work on Strict Mode on Advanced Guides?

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024 1

I'd like to work on Web Components

from ja.reactjs.org.

ossan-engineer avatar ossan-engineer commented on May 4, 2024 1

Hi, can I take Babel, JSX, and Build Steps ?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

#91 で、先週のフォークからの1週間で upstream (本家 reactjs.org) で起きたドキュメントの更新に対応するコミットが大量にマージされます。が、とりあえず翻訳絡みで影響があるのは Test Utils (#57, @takanorip) とフック絡みの各種記事 (@smikitky) のみです。他の方は現在の作業をそのまま続けて問題ありません。よろしくお願いします。

from ja.reactjs.org.

km-tr avatar km-tr commented on May 4, 2024 1

Can I take Reconciliation ?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024 1

@km-tr よろしくお願いします。Crowdinの翻訳をベースにする場合「突き合わせ」という訳語が使われていると思いますが、「更新検出処理」ないし「リコンシリエーション」で行くことになりましたのでご確認願います。
https://github.com/reactjs/ja.reactjs.org/wiki/%E8%A8%B3%E8%AA%9E%E3%81%AE%E7%B5%B1%E4%B8%80

from ja.reactjs.org.

ossan-engineer avatar ossan-engineer commented on May 4, 2024 1

Hi, can I take Passing Functions to Components ?

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024 1

I'd like to work on Styling and CSS

from ja.reactjs.org.

satotake avatar satotake commented on May 4, 2024 1

I would like to translate Higher-Order Components section.

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024 1

I'd like to work on Static Type Checking

from ja.reactjs.org.

km-tr avatar km-tr commented on May 4, 2024 1

I'd like to work on Virtual DOM and Internals

from ja.reactjs.org.

kik4 avatar kik4 commented on May 4, 2024 1

May I take Uncontrolled Components?

from ja.reactjs.org.

thayashi avatar thayashi commented on May 4, 2024 1

May I take Integrating with Other Libraries?

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024

I'd like to work on Composition vs Inheritance

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@Naturalclar Thank you! Probably you can use the Crowdin's work as a base. We have not established a formal reviewing process, but once you've made a PR, I or someone will take a look.

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024

As a model of translation, I think I want to work on a tutorial

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

@potato4d have you finished the glossary yet?

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024

After I finished translating glossary, it was meant as an example of translation of that glossary!

from ja.reactjs.org.

Naturalclar avatar Naturalclar commented on May 4, 2024

@smikitky Thank you! I've made a PR for translation of composition-vs-inheritance based on the translation on Crowdin
#5

from ja.reactjs.org.

sasurau4 avatar sasurau4 commented on May 4, 2024

I'd like to work on Lifting State Up 👍

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@potato4d Tutorial is one of the longest (and the most outdated) articles, and I believe your top priority for the next few days is to set up the bot. According to this comment, we need to establish a good workflow in a few days. Do you think you can handle both?

@sasurau4 Thank you!

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

@smikitky I think you can edit my issue with these additional notifications.

Why shouldn't we translate the external links? I'm curious because someone on the Spanish translation team was asking.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@tesseralis I just wanted to play it safe until members of all forks reach some consensus about this :) We may come up with some automated solution.

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

I don't think so... It depends on whether those links exist / are high quality in each language, right? Like, Japanese Wiki might have a good article on "declarative programming" but maybe Russian doesn't?

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

Will think of a way to do general translation guidelines.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

This is something we have to eventually discuss in the main repo. But React doc currently has literally hundreds of English-only external links (to Stack Overflow questions, YouTube videos, personal blog articles, Tweets, etc), which is atypical as the official documentation of a large library. I feel changing only a small part of them on an ad-hoc basis might not be a manageable option at least in the short term.

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

Sure, do you want to leave a comment on the main issue? Or if you want it to just be among translators I created a parent group for the internationalization effort: https://github.com/orgs/reactjs/teams/reactjs-org-internationalization

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

I don't think it's "ad hoc" to have the rule:

"If this link is for technical documentation and there is a high quality translation, link to the translation. Otherwise, keep the original English link."

There are copious links to non-translateable things like YouTube videos and StackOverflow and I think that is a issue to be handled by the English repo writers, but I don't think that should be a blocker.

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024

@smikitky
Since it seems better to prioritize the setting of Bot, it may be better to ask smikitky for the tutorial.
Could you please?

@tesseralis @smikitky

In the case of Vue document, when I find a document translated by MDN etc., I am changing the link.

For example, most people reading Japanese documents are Japanese.
And, in most cases the Japanese are seeking Japanese document.

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024

I just submitted a pull request to introduce TextLint.
If you have an opinion, please comment.

#6

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@saitoeku3 @sakito21 Thank you!

from ja.reactjs.org.

superyusuke avatar superyusuke commented on May 4, 2024

Home page ってまだ空いてますか?やります。

from ja.reactjs.org.

superyusuke avatar superyusuke commented on May 4, 2024

I have some questions.

  1. Why we should check the old translation? I think it is too old.
  2. How do we check the quality of the new translation? How is the reviewer determined?

If I shouldn't discuss here, change the place.

これ自分も賛成で、React のドキュメントは、初学者が最初に読む重要な資料なので、学習資料として意味が通る翻訳にしたいという思いがあるのですが、そういったクオリティチェックに関しては今の所どんな感じでしょうか?

from ja.reactjs.org.

uehaj avatar uehaj commented on May 4, 2024

Hi!
May I take "Add React to a Website" ? If there is other parts to be worked, please inform me.

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

@uehaj Could you take one of the "warnings" first? These are the pages that are linked in the console warnings that happen, and they're useful for people to look up!

from ja.reactjs.org.

uehaj avatar uehaj commented on May 4, 2024

@uehaj Could you take one of the "warnings" first? These are the pages that are linked in the console warnings that happen, and they're useful for people to look up!

I got it! Ill tackle the ones.

from ja.reactjs.org.

ossan-engineer avatar ossan-engineer commented on May 4, 2024

@tesseralis Sure! I'm starting off with faq-ajax. I'd really aprreciate it if you list and open up other FAQs.

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@summertree128 @uehaj @kik4 Updated the list. よろしくお願いします

from ja.reactjs.org.

sato11 avatar sato11 commented on May 4, 2024

Hi everyone!

I'm thrilled to see what's going on here and I'd really like to lend a hand.
Just wondered: @uehaj are you taking the whole Warnings section? If it's too much work to be done during this weekend, tell me so I can be of help.

@tesseralis @smikitky
While waiting for his answer, I'm working on Add React to a Website part as it seems vacant. Okay with you?

from ja.reactjs.org.

sato11 avatar sato11 commented on May 4, 2024

So are we stepping into advanced section?
Having finished the draft above I'd like to take JSX In Depth part, may I?

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@sato11 Yes, translating Advanced Topics was an extended goal, but since we've already run out of articles in Basics, I think we can move on.

from ja.reactjs.org.

shooontan avatar shooontan commented on May 4, 2024

May I take Fragments in Advanced Guides?

from ja.reactjs.org.

y-temp4 avatar y-temp4 commented on May 4, 2024

May I take Refs and the DOM in Advanced Guides?

from ja.reactjs.org.

sugoikondo avatar sugoikondo commented on May 4, 2024

Hi. May I take Code Splitting in Advanced Guides?

from ja.reactjs.org.

uenitty avatar uenitty commented on May 4, 2024

May I take Error Boundaries in Advanced Guides?

from ja.reactjs.org.

locol23 avatar locol23 commented on May 4, 2024

May I take Context in Advanced Guides?

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024

とはいえ今レビューに貢献くださっている人は Approve 権限がない人もいるはずなので、その場合はコメントで代替するなどになるかとは思います。

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

@potato4d まあ厳密ではなくても、「1人目がまず全体をちゃんと見るまで他の人は待つ」みたいな意識が共有できていればうまく動くかなと思います。私のところで作業をとどめすぎるのは良くないので、Approveはそこまでの流れを眺めて総合的に「これなら大丈夫」と判断してやります。

from ja.reactjs.org.

potato4d avatar potato4d commented on May 4, 2024

Approve は一応個人のオピニオンとして持っておいたほうが安全かなぁという印象がありました。特に件数が増えてくると重複してる部分を見るのが怪しくなりがちなので、誰かのレビュー(というよりその人からのレビュー対応)が落ち着いた頃にやったほうが、作業者の心理的にも優しそうな気がしています

from ja.reactjs.org.

koba04 avatar koba04 commented on May 4, 2024

@smikitky @potato4d なるべく明確にルール化されている方が、レビュイー/レビュアーにとっても安心だと思います。Approve自体は権限なくても示すことが出来るので、下記のフローを繰り返してマージボタンを押せる状態(権限ある人の 2 Approve)になったらマージするのは如何でしょう。

  1. レビュアー レビュー宣言
  2. レビュアー レビュー
  3. 作業者 レビュー対応
  4. (2〜3を繰り返し) レビュアー Approve
  5. マージの条件を満たした場合はマージ、そうでなければ別のレビュアーが条件を満たすまで1〜4を繰り返す

from ja.reactjs.org.

smikitky avatar smikitky commented on May 4, 2024

とりあえず #61 に移動して続けましょう…

from ja.reactjs.org.

sasurau4 avatar sasurau4 commented on May 4, 2024

I'll work on Rules of Hooks !

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

Hi all! I just synced from the original repo and there's some files that need re-translating! (Look for the <<<<<< HEAD comments)

#91

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

Excellent work everyone! We're almost done with the core pages!

@lightnet328 @euxn23 how is the progress on your pages? It's been a while, if you are unable to complete those, please let us know so we can reassign those to other people.

from ja.reactjs.org.

ginpei avatar ginpei commented on May 4, 2024

I'm going to take Component State in FAQ.

from ja.reactjs.org.

tesseralis avatar tesseralis commented on May 4, 2024

I'm going to open up ReactDOMServer since @euxn23 hasn't responded. Would anyone like to take it?

from ja.reactjs.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.