[Bug]: Issue with Sandpacks about react.dev HOT 7 CLOSED

Unfortunately, I old PR broke a couple of things in Sandpack. These changes introduced some edge cases and I hope this was the last one 🤞

from react.dev.

@danilowoz reverted the fix as it seemed to have broken all the sandpack instances in the site. This issue seems to have replicated the same that I reported here #6659 (comment). (sorry for the revert) cc: @rickhanlonii

from react.dev.

That was unexpected! For now, I'd try to fix the previous bug applying the following change
https://github.com/reactjs/react.dev/pull/6663/files#diff-8dd8662806ac667355c6bff8e8274df548eea48029d2c960160b7adb424501a4

I was able to reproduce it on Sandpack, but no idea what's causing that

from react.dev.

Thank you @danilowoz

Just to note that the sandpack for https://react.dev/learn/describing-the-ui#writing-markup-with-jsx

Shows the error the first time but not after scroll. Every other sandpack works correctly.

from react.dev.

@harish-sethuraman, there is still an issue on react.dev/learn/describing-the-ui#writing-markup-with-jsx. Can you confirm if this was introduced now?

Thanks @bondz, for reporting that

from react.dev.

I think it was introduced with this change. With 2.6.0 locally, it continues to show the Error message after the user scrolls away and back.

from react.dev.

In main I can see that the sandpack that @bondz has shared isnt working as expected. Shows blank screen occasionally.
have to confirm if this is affecting other sandpacks as well. From what I have seen it doesnt affect any other.

checked with older commits and seems like the preview takes time to load even after entering viewport and flickers. It didnt show loader rather when a preview (error) was already there it force replaced the preview again only after entering the viewport. Have attached the video from older commit without your changes (dan's commit) (url: https://react-1ctcjdyrh-fbopensource.vercel.app/)

from react.dev.