Simplify acessing response body about http-client HOT 7 CLOSED

Minor progress update: #70 has been implemented, which means that one can now use ReactPHP's normal stream primitives to buffer the whole request body:

$request = $client->request('GET', 'https://google.com/');
$request->on('response', function (Response $response) {
    \React\Promise\Stream\buffer($response)->then(function ($body) {
        echo $body;
    }, 'printf');
});
$request->end();

We're still working on a simpler API for #41 👍

from http-client.

While try I like to keep streaming without storing data posssible, maybe #29 is a way to achieve this? Now the question is which one do we want to be the default. I personally think that easy access to the response body should be the default, and streaming it in should be a secondary option

from http-client.

This likely depends on #70 in order to fix stream semantics first.

We may then provide normal stream buffering routines and should probably add an example here.

Once this is in, we may want to look into #41 to implement PSR-7 message body support.

from http-client.

@clue It seems the function \React\Promise\Stream\buffer is not exists. .

from http-client.

@slince This function is from the react/promise-stream package.

composer req react/promise-stream

from http-client.

@jsor thks

from http-client.

I'm closing this as it is already supported by the new HTTP client that has been merged into react/http via reactphp/http#368 You should upgrade as per #152 👍

from http-client.