Comments (5)
I'll get on it ASAP, thank you for opening an issue for it!
from react-play.
@erayalkis One doubt I got so clarifying. A play creator can add play cover in 3 ways.
- They provide a link to an online image in the play metadata while creating the play.
- They drop a cover.png in the play folder.
- They don't provide anything and framework add one default image.
I know in the case of 2 and 3 the social share of the play displays the cover image correctly on all the platforms. Have we taken care of the first case too in the code?
from react-play.
@erayalkis One doubt I got so clarifying. A play creator can add play cover in 3 ways.
- They provide a link to an online image in the play metadata while creating the play.
- They drop a cover.png in the play folder.
- They don't provide anything and framework add one default image.
I know in the case of 2 and 3 the social share of the play displays the cover image correctly on all the platforms. Have we taken care of the first case too in the code?
Yep! The first case should work fine as well, but if I missed an edge case I'll create a PR to fix it ASAP!
from react-play.
@erayalkis One doubt I got so clarifying. A play creator can add play cover in 3 ways.
- They provide a link to an online image in the play metadata while creating the play.
- They drop a cover.png in the play folder.
- They don't provide anything and framework add one default image.
I know in the case of 2 and 3 the social share of the play displays the cover image correctly on all the platforms. Have we taken care of the first case too in the code?
Yep! The first case should work fine as well, but if I missed an edge case I'll create a PR to fix it ASAP!
Sure thanks for conforming.
from react-play.
If the new changes don't fix the error, I've read that downgrading react-snap usually fixes the error, so we could also try that!
from react-play.
Related Issues (20)
- 🐛 [Bug report]: replace to meetup link HOT 5
- 🐛 [Bug report]: Testimonial card position HOT 5
- ✨ [Feature request]: add `release-drafter` ci/cd github action for automatic releases HOT 2
- ✨ [Feature request]: New UI For the Play Cards HOT 8
- 🐛 [Bug report]: change the link to meetup link HOT 4
- 🐛 [Bug report]: fix the alignment HOT 8
- 🐛 [Bug report]: fix header items alignment HOT 3
- 🐛 [Bug report]: add border to the play card on the home page HOT 4
- 🐛 [Bug report]: Hovering over the trending plays is not working properly when trying to select it from the bottom HOT 5
- 🐛 [Bug report]: ERROR: failed to solve: process "/bin/sh -c yarn install --frozen-lockfile" did not complete successfully: exit code: 1 HOT 3
- 🐛 [Bug report]: Layout shift occurring in the header section due to the initial position of the scrollbar on the page HOT 2
- No Popup for install in Mobile HOT 4
- Screen Css issue at both mobile and desktop view HOT 5
- Search bar issue when u open search bar in mobile its not responsive HOT 5
- Important: migrate from ReactJS to NextJS HOT 5
- Design for Footer Component In NextJS HOT 3
- Design for Contributor Section Component In NextJS HOT 3
- Design for Navbar Component In NextJS HOT 3
- Architecture/Design proposal for next-js migration HOT 8
- [Next.JS Migration]: Next JS initialization HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-play.