Giter VIP home page Giter VIP logo

Comments (5)

erayalkis avatar erayalkis commented on September 13, 2024 1

I'll get on it ASAP, thank you for opening an issue for it!

from react-play.

atapas avatar atapas commented on September 13, 2024 1

@erayalkis One doubt I got so clarifying. A play creator can add play cover in 3 ways.

  1. They provide a link to an online image in the play metadata while creating the play.
  2. They drop a cover.png in the play folder.
  3. They don't provide anything and framework add one default image.

I know in the case of 2 and 3 the social share of the play displays the cover image correctly on all the platforms. Have we taken care of the first case too in the code?

from react-play.

erayalkis avatar erayalkis commented on September 13, 2024 1

@erayalkis One doubt I got so clarifying. A play creator can add play cover in 3 ways.

  1. They provide a link to an online image in the play metadata while creating the play.
  2. They drop a cover.png in the play folder.
  3. They don't provide anything and framework add one default image.

I know in the case of 2 and 3 the social share of the play displays the cover image correctly on all the platforms. Have we taken care of the first case too in the code?

Yep! The first case should work fine as well, but if I missed an edge case I'll create a PR to fix it ASAP!

from react-play.

atapas avatar atapas commented on September 13, 2024 1

@erayalkis One doubt I got so clarifying. A play creator can add play cover in 3 ways.

  1. They provide a link to an online image in the play metadata while creating the play.
  2. They drop a cover.png in the play folder.
  3. They don't provide anything and framework add one default image.

I know in the case of 2 and 3 the social share of the play displays the cover image correctly on all the platforms. Have we taken care of the first case too in the code?

Yep! The first case should work fine as well, but if I missed an edge case I'll create a PR to fix it ASAP!

Sure thanks for conforming.

from react-play.

erayalkis avatar erayalkis commented on September 13, 2024

If the new changes don't fix the error, I've read that downgrading react-snap usually fixes the error, so we could also try that!

from react-play.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.