Giter VIP home page Giter VIP logo

Comments (2)

HadrienGardeur avatar HadrienGardeur commented on September 25, 2024

Well, I can imagine more edge cases.

Let's imagine the following EPUB:

META-INF/encryption.xml
cover.jpg
EPUB/package.opf
EPUB/chapter1.html
EPUB/chapter1.mp3
EPUB/navdoc/toc.html
EPUB/smil/chapter1.smil

Your suggestion should handle two problematic situations:

  • accessing META-INF/encryption.xml
  • accessing cover.jpg

For EPUB/navdoc/toc.html and EPUB/smil/chapter1.smil do you calculate everything based on the relative path of the Navigation Document, NCX and SMIL?

The Navigation Document would reference ../chapter1.html but with your suggested change, we would have to indicate EPUB/chapter1.html in the manifest.
Same idea for NCX and SMIL.

I can't remember if in EPUB content documents, links can start with a / with for example:

<a href="/EPUB/chapter1.html" />

That specific case would be very problematic because the navigator would attempt to access https://r2.org/EPUB/chapter1.html instead of https://r2.org/moby-dick.epub/EPUB/chapter1.html.

from architecture.

danielweck avatar danielweck commented on September 25, 2024

I think we should close this issue, as this is the active one: #38
(they are cross-referenced, so we won't loose the discussion thread here)

from architecture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.