Giter VIP home page Giter VIP logo

Comments (2)

JayPanoz avatar JayPanoz commented on June 5, 2024

Ah yeah so at the moment, it is indeed intentional. As far as I can remember, we hit some edge cases quickly with some samples, in which authors put a sepia background for instance, and the “day theme” was therefore becoming useless and confusing – feels like a bug.

On a related note, neither users not authors/publishers seem to be really happy when background-color for the html element doesn’t cover the entire screen/browser window and is only covering the iframe or webview. That was indeed quite a popular feature request from the e-production community when I run some surveys/drive discussions to list their issues/requests.

So I don’t have any solid guidance for this case yet. Maybe this snippet will change at some point but we’ll have to fix the UX issues first.

Everything related to reading modes is kind of nightmarish since there are a lot of CSS hacks which can go wrong out there. So to be honest the current implementation tries to get around those issues in the simplest ways I could find. In any way, the “day mode” should work as expected, so it probably means creating a “publisher reading mode” (with a default in case background-color + color are not declared).

Moreover, reading modes are part of “Chrome” in our current classification, see issue #16. What it means is that, like pagination/scroll, it is a basic setting that should always work the same for the user and never break her/his expectations, whatever it takes. So I’m obviously open to discuss our options since it puts a burden on authors.

from readium-css.

JayPanoz avatar JayPanoz commented on June 5, 2024

Superseded by #46 so we should probably discuss this topic in the other issue.

from readium-css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.