Comments (8)
from readium-css.
Hmmm, I can see two issues in <head>
at first sight:
ReadiumCSS-before.css
is loaded after all other stylesheets while it should come first (before authors’ stylesheet(s);- the ReadiumCSS stylesheet used are the ones for CJK in vertical writing (for RTL, they should be the one in the
RTL
folder, which is this one)
Do you get the same result with the RTL stylesheets?
from readium-css.
Also, I would recommend dividing this sample into 2 because, in and of itself, it exactly is an edge case we agreed to not handle back in December 2017 as the EPUB spec provides zero guidance for it.
So it would be a better idea to isolate Japanese from Arabic/Hebrew.
from readium-css.
Hi, the order doesn't matter, it will have the same effect. I have double checked it in Safari.
This one in picture is modified by myself on Mac, so it has this order. Don't worry. The webpage generated by Streamer has correct order.
The book is using CJK vertical mainly, and this cover html is mark as xml:lang="ja"
Logically, we should use CJK vertical. What is the reason to use others?
I just checked the css file under rtl, it will have some difference but still been cut off.
from readium-css.
OK I’ll take a look and report back.
But if we end up discovering we need to isolate h1
wrapping svg or images from others, there’s nothing we can do in CSS to achieve that.
from readium-css.
Thanks. I also found if the h1 has a width:(some number smaller than the container): important!
It will also work fine. But I am not CSS expert. You guys should has better solutions.
from readium-css.
OK so I was able to reproduce this issue… without loading any ReadiumCSS stylesheet.
h1
indeed has no dimensions set (width
and height
) so it can’t constrain the nested SVG which is 100%
of… nothing. This explains why putting a width
on h1
works, as you reported in the comment above.
With ReadiumCSS Stylesheets loaded we got this (note columns are on the y-axis
).
I’m reluctant to safeguard h1
there, as some may well be more than the width of the page so our best option is probably switching to viewport width (vw
) there. But that is not a perfect solution as it will indeed create a blank page after.
I’ll try deploying the change on the develop
branch ASAP so that we can see if it is good enough. But there’s not much we can do considering it doesn’t even work properly when kept untouched (and there’s consequently an authoring issue).
from readium-css.
As said before to @iaomw, this edge case EPUB sample must be put on the side for RTL study and only used for check if the issue we see here can be solved easily. We must not spend too much time on this.
from readium-css.
Related Issues (20)
- CSS HTML5 patch causes some digits to descent from baseline HOT 4
- CSS HTML5 patch causes some digits to descent from baseline
- CSS HTML5 patch causes some digits to descent from baseline
- Long hyperlinks overlap on the next column HOT 3
- forcing "start" text alignment (left or right depending on document language) does not work with "inherit" HOT 1
- Overflow on long words HOT 4
- in scroll mode, "page width" (line length) is too short HOT 19
- Target for Browser/Webview support? HOT 3
- Dist stylesheets and minification HOT 4
- Default Stylesheet for non-reflowable EPUB contents e.g. reading mode HOT 2
- ReadiumCSS Reset/Unset
- Fonts update HOT 2
- Letter-spacing for japanese HOT 9
- Overview of new CSS specs of interest HOT 2
- Improve handling of body overflow HOT 1
- Defining design guidelines based on CSS support HOT 2
- User setting to disable/hide ruby
- Park support of pagination for vertical writing
- Remove responsive columns to make pagination more reliable HOT 8
- More often than not, "cover" images (first spine item in the reading order, full-page picture) cause excess blank before/after HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from readium-css.