Glob.resolveGlob() is veeeery sloooow about swiftlint HOT 6 OPEN

Thank You for your answer. I will try and report back.

from swiftlint.

This is a known issue that #5157 tries to address. It manifests when wildcards used in the excluded list resolve to a lot of files.

Changes in this area caused some slight differences in the set of linted files in the past which led to other issues. We should be really sure that a changed algorithm still produces the same matches. As pointed out in a comment, real world testing is difficult for us. So if you'd like to support, please try with #5157 if the performance issue is fixed, but the output is unchanged at the same time.

Off topic: Instead of your custom rule private_iboutlet_variable you might want to try the built-in (and opt-in) rule private_outlet.

from swiftlint.

We should be really sure that a changed algorithm still produces the same matches.

Short answer: it doesn't seem so. Give me a bit of time for a deeper analysis.

from swiftlint.

Ok, I figured it out: Looks like the exclude: part of custom rules is not used in the fix. To be honest the regex in our config is highly questionable and needs to go away. So from my perspective the change is good to go.

But in the interest of science and correctness that part of the fix doesn't work. See screenshot. brew 0.53.0 of the left, fix on the right. (I removed the (…/…) part of the output and sorted the lines. I can post the playground code if you are interested.)

from swiftlint.

I just realized there is a line - "**/*Test*" in the global exclude section, so the whole exclusion seems broken.

from swiftlint.

Thanks for playing around with the fix!

Looks like the exclude: part of custom rules is not used in the fix.

Yes, it's not part of the fix but should be taken into account at a later step when the rule runs. So if that doesn't work, there might be another issue.

I just realized there is a line - "**/*Test*" in the global exclude section, so the whole exclusion seems broken.

I could reproduce that in a unit test. The thing here is that the last component could match files in the previous folder(s) or all folders (and their contained files) named *Test*. That should be handled correctly now in the updated PR. Please try again.

from swiftlint.