Giter VIP home page Giter VIP logo

Comments (7)

magnificode avatar magnificode commented on June 20, 2024 1

I now realize that there's another PR that was put out for this (didn't see the Trello and claimed here, sorry). However, I think the PR I put up is a bit more configurable and uses the <Button> component from ChakraUI internally instead of just <PseudoBox> which has less functionality built into it (<Button> uses <PseudoBox> internally).

I'd love for you to collaborate with the folks working on that ticket! If leveraging <Button> over <PseudoBox> is more flexible then we definitely want to consider it. Andy has been super receptive to feedback!

from rbb-website.

andria-dev avatar andria-dev commented on June 20, 2024

Working on it 👍

from rbb-website.

andria-dev avatar andria-dev commented on June 20, 2024

Done! #34

from rbb-website.

andria-dev avatar andria-dev commented on June 20, 2024

I now realize that there's another PR that was put out for this (didn't see the Trello and claimed here, sorry). However, I think the PR I put up is a bit more configurable and uses the <Button> component from ChakraUI internally instead of just <PseudoBox> which has less functionality built into it (<Button> uses <PseudoBox> internally).

from rbb-website.

magnificode avatar magnificode commented on June 20, 2024

@ChrisBrownie55 I am so so sorry, I hadn't had a chance to assign this to the person who had the ticket in progress as they had not been invited to the GitHub org yet (jumped into meetings directly after I created it).

We have in progress work happening via this PR #23 - is there any chance you can work with them to see what we can do about leveraging any of the work you've done here?

This is 100% on me for not finishing this ticket out completely before creating it, so sorry for the confusion.

from rbb-website.

andria-dev avatar andria-dev commented on June 20, 2024

Will do, thank you, sorry about the confusion.

from rbb-website.

magnificode avatar magnificode commented on June 20, 2024

@ChrisBrownie55 no need to apologize at all. On me for trying to juggle too many things at once :)

from rbb-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.