Giter VIP home page Giter VIP logo

Comments (3)

chapayGhub avatar chapayGhub commented on May 23, 2024

May be this is a solution

  func itemWidth(for pagingItem: T) -> CGFloat {
    if let width = widthCache[pagingItem] {
      return width
    } else {
      let width = widthForPagingItem?(pagingItem, false)
      width.flatMap({ widthCache[pagingItem] = $0  })    //CHANGED LINE  
      return width ?? options.estimatedItemWidth
    }
  }

And I Found another one issue in this sample:

struct ImageItem: PagingItem, Hashable, Comparable {
  let index: Int
  let title: String
  let headerImage: UIImage
  let images: [UIImage]
  
  var hashValue: Int {
    //The sum of two Integer throw overflow exception in my simulator 
    //return title.hashValue + headerImage.hashValue
    
    // I think this fix is good for example app 
    return title.hashValue/2 + headerImage.hashValue/2   //CHANGED LINE  
  }
  ......

from parchment.

rechsteiner avatar rechsteiner commented on May 23, 2024

Thanks for the report. I’ll take a look!

from parchment.

rechsteiner avatar rechsteiner commented on May 23, 2024

Yeah, looks like the hashValue implementation causes an integer overflow on older devices. Added a fix for this in #140. Thanks for catching that 🙌

from parchment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.