Table widget: tbody row indexing starts from 1 when there's a row in table header about widgetastic.core HOT 4 CLOSED

Spend some today together with @izapolsk and can confirm it was resolved in latest 0.30.3 (but reproducible in previous versions). Now some fixes are needed on our end. Thanks @mshriver @izapolsk !

from widgetastic.core.

@abalakh this should be fixed by #125, just merged.

This would be a great addition to our unit tests for the table.

from widgetastic.core.

@mshriver unfortunately, now it's only worse :( That or maybe some next change introduced very weird regression.
Couple of details about that table: initially, when user opens the page, it has 1 row with 1 td with colspan=5. Then user hits 'Add rule' button, and one extra tr appears before mentioned one:

Previously (with 0.21.x) it was working ok. Now i can't figure out what's going on:

• table.read() returns empty list
• table[0][x] returns the message from that second row with colspan. Same after table.clear_cache()
• table[0].read() returns a dict with headers as keys and that message as values (would be ok if i was accessing [1] element)
• table[0][x].position == 0
• same with table[1][x].position == 0 and .text - it returns message from second row. So, basically, both [0] and [1] rows are pointing to second row
• attempt to use fill like table[0][4].widget.fill() actually tries to fill [0][0] widget (i guess since it thinks that [0] - is second row, and second row has colspan, so this behavior might be ok)

Original issue with wrong index can be worked around, but i can't find any workaround for this one, basically i need a way to fill that first row somehow.

from widgetastic.core.

Good to hear @abalakh, all credit to @izapolsk though!! :)

from widgetastic.core.