Breaking Change about redis-rs HOT 10 OPEN

^^^^^^^^ the trait `FromRedisValue` is not implemented for `serde_json::Value`

If I specify type it works let json_data: String, but I don't know the structure, it's a json data, so it's serde_json::Value

from redis-rs.

@zebede22 are you sure this isn't an issue with the redis-macros crate? can you provide an example that relies only on redis-rs?

from redis-rs.

@zebede22 are you sure this isn't an issue with the redis-macros crate? can you provide an example that relies only on redis-rs?

Yes, redis-rs is not related.
Here same code without the redis-crate:

 let json_data: Value = conn.json_get(key, "$").await?;

Error:

error[E0277]: the trait bound `serde_json::Value: FromRedisValue` is not satisfied
   --> src/redis.rs:14:33
    |
14  |     let json_data: Value = conn.json_get(key, "$").await?;
    |                                 ^^^^^^^^ the trait `FromRedisValue` is not implemented for `serde_json::Value`
    |
    = help: the following other types implement trait `FromRedisValue`:
              bool
              isize
              i8
              i16
              i32
              i64
              i128
              usize
            and 44 others
note: required by a bound in `redis::JsonAsyncCommands::json_get`

from redis-rs.

is serde_json::Value supposed to implement FromRedisValue? if so, where is it implemented?
Again, that's not a redis-rs type, so it's hard for me to understand whether this is an issue in redis-rs or not.

from redis-rs.

is serde_json::Value supposed to implement FromRedisValue? if so, where is it implemented? Again, that's not a redis-rs type, so it's hard for me to understand whether this is an issue in redis-rs or not.

It's been working until 0.24 change.

Also, how to get a json from an endpoint where you have no exact json structure? how it can be done without serde_json?

from redis-rs.

how to get a json from an endpoint where you have no exact json structure? how it can be done without serde_json?

You can use a HashMap, or a string. We're trying to understand what changed, and the more moving parts there are, the harder it is to pinpoint the source of the issue.

It's been working until 0.24 change.

Maybe, but I need a minimal reproducible example in order to understand the issue. If you want to create a small project to simulate the problem, that will be very helpful.

from redis-rs.

Sounds like you have two separate versions of redis in your dependency tree. Looking at the redis-macros crate it does infact have redis version 0.23 as a dependency which is not semver compatible with 0.24.

-> Not related to the redis crate, you just need to use the same version or ask redis-marcros to update the dependency.

from redis-rs.

This is still happening, just happened to me after upgrading. I believe this is a redis-rs issue rather than another lib issue.

from redis-rs.

Check your Cargo.lock or cargo tree, it is very likely you have two separate versions of the redis crate in your dependencies.

from redis-rs.

from redis-rs.