Giter VIP home page Giter VIP logo

Comments (7)

xetorthio avatar xetorthio commented on May 9, 2024

This is not expected at all. The master branch in Jedis is always stable.
Have in mind that Jedis is always developed agains the latest changes in the master branch, so probably you don't have the latest Redis, which makes these tests to fail.

from jedis.

tonit avatar tonit commented on May 9, 2024

okay, makes sense. Running Tests against Redis Master:
Results :

Tests in error:
trySharding(redis.clients.jedis.tests.ShardedJedisTest)
tryShardingWithMurmure(redis.clients.jedis.tests.ShardedJedisTest)

Tests run: 151, Failures: 0, Errors: 2, Skipped: 0

from jedis.

xetorthio avatar xetorthio commented on May 9, 2024

Are you running the tests against two instances of Redis? You should run 2 instances, one with the redis.conf and the other one with redis2.conf
It is the same configuration but different port, so Jedis can test sharding.
Will add this to the README ASAP!

from jedis.

tonit avatar tonit commented on May 9, 2024

Mhh okay, this makes sense. How about separating unit tests (run automatically, against a redis mock) and optional (profile based) integration tests (where you need certain dbs set up)..Just a suggestion because "mvn clean install" is usually not expected to need manual software set up. I agree you have the tests, just don't mix them up. Just my idea. At least document that somewhere ;)

from jedis.

xetorthio avatar xetorthio commented on May 9, 2024

Yes... documentation is missing and I feel bad about that, so I will do it ASAP (which means later this week).
About a mock... I don't know. I think more than 90% of the tests require Redis to be able to run. Probably there is a way to run redis from maven before the tests. That should be enough. I will add the doc and than try to do that.

from jedis.

tonit avatar tonit commented on May 9, 2024

ok, tests - if you know what to set up before - work.

from jedis.

xetorthio avatar xetorthio commented on May 9, 2024

Sorry about that. Just added that info to a new "I want to contribute!" section on the main page. Feel free to add any missing information. Thanks again!

from jedis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.