[BUG] hIncrBy from lua "ERR value is not an integer or out of range" with numeric values of the form n * 100,000,000 in redis 7.2, but not 6.2 or 7.0 about redis HOT 5 CLOSED

redis 7.0 behaves the same as redis 6.2, the error only appears in redis 7.2. For reference, these are the redis versions (though I'm just pulling 7.0 and 7.2 tags from docker).

good

redis_version:7.0.13
redis_build_id:8a3b90fcd3d0bc72
os:Linux 6.7.6-200.fc39.x86_64 x86_64

bad

redis_version:7.2.4
redis_build_id:30468499a8bc54fe
os:Linux 6.7.6-200.fc39.x86_64 x86_64

from redis.

@mdouglass thanks, ths is a bug introducted by #10587.
fpconv_dtoa uses exponential expressions to convert 1000000000 (2e+8) and lead to convert failed in getLongLongFromObjectOrReply().
do you wanna make a PR to fix it?

from redis.

yes, it is a bug introduced in #10587. so it looks like we should revert the changes in script_lua.c in #10587? or should we find a way to support converting it in string2ll (i feel it is a bit too much)

from redis.

@enjoy-binbin i don't like to put it in string2ll.
may be we can check if the lua_Number is a integer by (long long)num == num, then
decide whether to use fpconv_dtoa or ll2string.

from redis.

I think that was enough guidance that I was able to figure out what to do. Let me know if there is anything else that I can do to make this work better.

from redis.