Giter VIP home page Giter VIP logo

Comments (5)

dvirsky avatar dvirsky commented on May 22, 2024

Yeah, it's been in the TODO for ages, and it should really be trivial to implement :) Also generating snippets on the fly would be nice.

from redisearch.

dvirsky avatar dvirsky commented on May 22, 2024

(hint: PRs would be welcome ;) )

from redisearch.

dvirsky avatar dvirsky commented on May 22, 2024

BTW - not really a workaround, but you can of course retrieve the IDs and then do HMGET on them, the documents are stored simply as plain redis hashes.

from redisearch.

dvirsky avatar dvirsky commented on May 22, 2024

@mnunberg you can take this one, it's pretty straightforward.

  1. The API should look like RETURN {num} {field} {field}.... Having the number allows us to have field names that are reserved words, similar to INKEYS, INFIELDS, etc.

  2. This should be reflected in the RSSearchRequest struct.

  3. Field names must be copied to the request, because the query will be execute on a separate thread after the original caller's auto memory has finished freeing them

  4. RETURN 0 is valid and equivalent to NOCONTENT. I wouldn't enforce a limit on the number of fields, but make sure that it's not overflowing argc of course.

  5. Non indexed fields that are not in the schema are allowed - the schema only refers to indexing, it is perfectly okay to add documents with fields outside the schema. Just use the fields for the RM_HashGet call.

  6. fields should be case sensitive in this context. There are places they aren't but I want to move to a fully case sensitive mode of operation, we can start here :)

  7. When you're done, don't forget:
    a. a python test.
    b. document this in Commands.md
    b. please add this feature to the python and java clients.

Thanks!

from redisearch.

dvirsky avatar dvirsky commented on May 22, 2024

Fixed in current master, will be included in next release.

from redisearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.