Giter VIP home page Giter VIP logo

Comments (7)

prnam avatar prnam commented on May 8, 2024 1

Hey @ollopaci,
Thank you for checking the issue. I was not really sure if any of the issues I raised would be accepted.

Now that this one is accepted, wanted to know if it is open for me / anybody to contribute. Could not find any labels to know; what indicates any of the issue are open to contribution?

from redisinsight.

ollopaci avatar ollopaci commented on May 8, 2024 1

Hi @prnam. Of course it is open for anyone to contribute. We actually would really like to encourage that. Taking your proposal and will create a corresponding label for this. Thank you!

from redisinsight.

ollopaci avatar ollopaci commented on May 8, 2024

Thank @prnam for the observation. We will address this in the next release.

from redisinsight.

prnam avatar prnam commented on May 8, 2024

Thank you for your timely response @ollopaci . I have raised the PR that will close this issue. Looking forward for CI approval for first time contributors, review and hoping everything will be good to merge 🤞

from redisinsight.

ViktorStarostenko avatar ViktorStarostenko commented on May 8, 2024

Hi @prnam, we have discussed this issue internally one more time and came to the conclusion that the "Key Type" is also an acceptable term and should clearly define its purpose, also using the "Key type" will allow us to be consistent with RediSearch team.
But I'd really like to thank you a lot for your input and contribution, this is very helpful.

from redisinsight.

prnam avatar prnam commented on May 8, 2024

Okay, @ViktorStarostenko . Thank you for reviewing and sharing the decision. 🙂

I assume no action item from my end as such; you or the team will take necessary action on the issue and PR, right?

from redisinsight.

ViktorStarostenko avatar ViktorStarostenko commented on May 8, 2024

@prnam, yes, we will take care of them.

from redisinsight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.