Giter VIP home page Giter VIP logo

Comments (4)

gkorland avatar gkorland commented on June 12, 2024

Yes it seems like there is a timing issue in this test

from jredistimeseries.

ashtul avatar ashtul commented on June 12, 2024

@felipecsl
The first time you call ts.incrby you are using the implicit server Unix time. The second time you are using the time from your laptop.
This means your second timestamp might be prior to the first one and you will get an error.
Please note, ts.incrby will update the latest value if it has the same timestamp as the latest sample. If it earlier than the latest, you will get the error message "ts.incrtby...".
I would suggest to remove this test as it might depend on the system on which it is ran.

from jredistimeseries.

felipecsl avatar felipecsl commented on June 12, 2024

you could easily work around that issue by using a current time provider that you could override during tests using a fixed current time. if you don't care about fixing it, then by all means delete the test :)

from jredistimeseries.

filipecosta90 avatar filipecosta90 commented on June 12, 2024

you could easily work around that issue by using a current time provider that you could override during tests using a fixed current time. if you don't care about fixing it, then by all means delete the test :)

Agree @felipecsl - given that we want to test incrby and decrby and not the auto-ts feature on this test. The PR #26 addresses this issue.

from jredistimeseries.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.