Setup VPC and stop relying on IAM user's default VPC about deployment-automation HOT 5 CLOSED

I would suggest the logic should be:
use explicit VPC is a variable is set
use default VPC if it exists
create a vpc if neither

from deployment-automation.

We now support default vpc and provided vpc. I am leery of adding vpc creation as I feel that oversteps our boundary. Would appreciate thoughts.

from deployment-automation.

The issue that prompted me to create this ticket was that I had no default VPC. Maybe I deleted it for some reason, but I think it didn't exist by default in my sandbox account. For people in this same situation they would be unable to use the default settings of this project.

If we don't want to create a VPC for whatever reason without the user being explicit about it, then another approach could be to require the user to provide VPC details?

from deployment-automation.

Our current default action is to use the default VPC. If the user provides a VPC ID we build with that. I don't see a real need to force the user to create a VPC if they have a default one (which people do use... although they shouldn't) and haven't changed the necessary variables to add their own VPC into the module?

#147

from deployment-automation.

Summarizing (lmk if I'm incorrect):

• The original issue is specific to the default VPC: if the default VPC does not exist and you try to use it with Ansible, this will fail
• There's an idea to create a default VPC if it does not exist -- I'd rather we fail hard if a person is trying to use this with a VPC and they deliberately deleted the default VPC behind the scenes
• A potential last idea is to require the user to provide VPC details, but IMO this would break any flows where people don't want to use a VPC at all
• It sounds like our current approach is the best compromise: use explicit VPC is a variable is set, use default VPC if it exists and variable is set, fail if variable is set and the VPC being used does not exist

closing this as done given ^^^ but please lmk if you disagree

from deployment-automation.