Identity function, hidden gotchas and 300-400ms to dispatch your actions about redux-actions HOT 5 CLOSED

onChange passes an event as parameter to the action creator as payload, that's correct.

What you can do instead is writing something like this:

<input type="checkbox" onChange={() => props.toggleBaseline()}>

or

export default connect(state => state.debug, dispatch => ({
  toggleBaseline: () => dispatch(toggleBaseline())
}))(DebugGrid)

from redux-actions.

@timche Yes, but that is not the point, point is that you can easily run into confusing issues (at least I was able to) with this approach. In general this sounds like a trick default behaviour. Did you see a problem at that time when I asked about it in my post?

Also use of arrow functions in there is discouraged https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md

I workarounded this with:

const makeActionCreator = (type, payloadCreator, metaCreator) =>
  createActionCreator(type, payloadCreator || (() => {}), metaCreator)

But that is just workaround.

from redux-actions.

I know that, it was only an example to keep it short ;)

I don't really get your point then, sorry :/ The identity function takes an parameter as payload as it is stated in the docs. What's confusing about this?

from redux-actions.

@timche I am sorry for not being clear. I tried my best in explanation above and that if you follow normal path with that behaviour it's easy to get into a trap.

"Normal path" is the following:

Define action creators => pass action creators to connect => call them directly from JSX event handlers => trap

This path looks normal to me, it's recommended path in Redux docs and it leads to a problem, which, presumably a lot of people would not even realize (unless they use Redux Dev Tools).

I understand that it maybe only me and the rest is doing it just fine and understand everything and stuff =), that's why I tried to ask if you saw a problem back then while reading my comment. If you did not then you part of the community who fell into a trap.

If subjectively this is valid problem, then it requires some attention. I don't want to jump into solutions right away, before we align that it is a potential issue for newcomers.

Does this make sense?

from redux-actions.

Tbh, I don't see an issue with this, because event handlers are working like expected for me personally (or see here). If anyone should see a problem here as well, then I'm willing to reopen this issue again, otherwise I'll close it for now.

from redux-actions.