[email protected]: Empty object check error about redux HOT 4 CLOSED

Out of curiosity, what's the use case for Object.create(null) here? What are you doing with it in code?

from redux.

I use it just to create an empty object for storing data, and later I will add keys and values to this empty object. In some cases, it just makes it convenient for me to have fewer declarations, for example, declaring AnyObject explicitly.

const data = Object.create(null);
data.a = 1;

const data: AnyObject = {};
data.a = 1;

from redux.

@zhe-he : I'm okay with merging the fix, but tbh I'm not sure I see an actual reason to use Object.create(null) here :) the AnyObject example is actually shorter, and also more clear about what's going on.

from redux.

Well..., I'm not trying to convince you which method is better, I think any method is fine, it's just based on my personal habits.
I don't like explicit declarations, so I used the any returned by Object.create. At the same time, I personally think that the Object.create(null) loop will be a bit faster, so I used this, below is the time spent on testing.

// 2 lines
import { AnyObject } from "@/@types";
const data: AnyObject = {};

// 1 line
const data = Object.create(null);


// 2 lines or 9 lines
export type M = {
    name: string;
    value: string;
    child?: M[];
}
export type O = {
    [props: string]: M
}
// import { O } from "@/@types";
const map: O = {}

// 1 line
const map = Object.create(null);

from redux.