Validation issue in Binding.mutateToFromViewValidated about gjallarhorn HOT 4 CLOSED

It seems like a bug to me, more simple mcve below:

let test() = 
    let value = Mutable.create ""

    use dynamicVm = Binding.createSource ()
    let validator = (notNullOrWhitespace >> hasLengthAtLeast 3)
    Binding.mutateToFromViewValidated dynamicVm "Value" validator value
    
    dynamicVm.IsValid |> printfn "empty string: %A" //true, should be false 
    value.Value <- "Valid"

    dynamicVm.IsValid |> printfn "Valid string : %A"  //true, should be true

    value.Value <- "-"
    dynamicVm.IsValid |> printfn "Invalid string : %A"  //true, should be false 

from gjallarhorn.

Okay, I guess I found why it happened. There a two reasons:

1. The part of code that responds for updating the mutable.
   https://github.com/ReedCopsey/Gjallarhorn/blob/master/src/Gjallarhorn/IO.fs#L95-L99

it seems like updating only when changing validation result instead of just a value, so I think it should be something like that:

    let subscription = 
        validated
        |> Signal.Subscription.create(Option.iter(Mutable.set input))

2. About "decorator".
   https://github.com/ReedCopsey/Gjallarhorn/blob/master/src/Gjallarhorn/IO.fs#L88-L89

MutatableInOut inherit InOut instead of ValidatedInOut, so there:

https://github.com/ReedCopsey/Gjallarhorn/blob/master/src/Gjallarhorn.Bindable/BindingSource.fs#L125-L128

can't be convert to ValidatedInOut

from gjallarhorn.

Thank you @FoggyFinder - You were right about the underlying problem - changing the inheritance solved this. Added 2 new tests for this as well.

from gjallarhorn.

Thank you for reacting to this so quickly and fixing the issue!

from gjallarhorn.