Modifying labels with addon enabled causes browser to hang and pop up warning about a script about refined-github HOT 15 OPEN

Sure, this is what I see (apologies if I'm missing something, I'm definitely not a Javascript developer):

from refined-github.

This issue doesn't happen if the quick-comment-edit feature is disabled.

from refined-github.

To those using Firefox, can you try using an older version of Refined GitHub? Like from November

quick-comment-edit also caused performance issues, disabling it in the newest version fixed it for me.

Just tried version 23.11.3 released November 3th (with quick-comment-edit enabled) and the performance issues are still there, but much less. At least it doesn't lock up the tab completely...

from refined-github.

Can you show what code appears when you click "Debug script"?

Related:

• #7116

from refined-github.

@fregante I've added you as a collaborator on https://github.com/dakrone/label-test, where I've manually created 385 labels so far (I got that far before Github started hitting me with errors about rate-limits) there are now 500 labels, and the problem reproduces. In case it's helpful for debugging.

from refined-github.

Even with quick-comment-edit disabled it can happen, but that's just incidental.

from refined-github.

Oh, I checked again, it still happens with quick-comment-edit disabled.

from refined-github.

I now found out that you have to type slowly for it to work. So I'm guessing there's another reason why this happens. Any way we can deliver debug info of some sorts?

from refined-github.

@fregante is there a subset of refined-github that I can disable to avoid this in the short-term? I've had to disable it entirely since I do a lot of daily label changes.

from refined-github.

That's what I'm trying to figure out. I disabled those 4 features an I still have trouble opening long PRs in Safari.

from refined-github.

With quick-comment-edit enabled:

With quick-comment-edit, locked-issue and wait-for-checks disabled (these 2 are disabled via a hotfix on my normal firefox instance but were enabled in the dev env):

The code at quick-comment-edit does say:

	// TODO: Replace with :has selector
	observe(preSelector + '.js-comment.unminimized-comment .js-comment-update', addQuickEditButton, {signal});

Is there maybe a performance reason why it should use :has?

(lol, after posting this issue it seems I still have the quick comment edit button, so I guess disabling a plugin works differently in a dev env)

from refined-github.

quick-comment-edit definitely causes perf problems in firefox indeed. One very simple way for me to trigger the slowness is resizing the browser window a few times in a row. Once in a while the page will completely freeze and not redraw for multiple seconds.

from refined-github.

To those using Firefox, can you try using an older version of Refined GitHub? Like from November

I have a suspicion that the "slow" code is in the CSS, because I can't think of a reason why removeChild would not be instant. I'd consider it a browser bug that affects RG users :(

from refined-github.

Are there any docs on how to revert to such version?

from refined-github.

You can download them from https://addons.mozilla.org/en-US/firefox/addon/refined-github-/versions/

from refined-github.