Comments (14)
Tags that include the word nightly
and tags that don't have a version (minimum \d\.\d
expected) are now excluded:
This specific issue can stay open because I'd still want ordering, but I think this can only be done via API. The API can return the tags in order of creation.
I don't want to get into the sorting of tags out of the current HTML snippet because soon enough there will be a repo with 1.0.0
and release/2.0.0
and beta/2.0.0
and I can't figure out every combination of that.
from refined-github.
So it seems that GitHub lists tag in alphabetical order:
We expect the "earliest tag" to appear last on that list, because that's generally the case.
To fix this issue and to future-proof this feature, I'd be open to use the API, if it's possible. I think we went with this snippet because the API doesn't expose this information, calculating it would be expensive.
from refined-github.
Thank you @aryairani π
from refined-github.
(Actually I think it might the same issue described in #7206, but the submitter mistakenly focused on "pre-release" vs "release" metadata, which I think are a red herring which led to the issue being closed prima facie.)
from refined-github.
We just ask GitHub for the order, so you can change it by changing the time of creation of the tags. But the core logic remains: this pattern requires
--force
, so it's not something we should support
Sorry, I still didn't understand. I do want pre-release tags to be included in the results. #7206 is asking to exclude pre-releases, but I'm not asking for that. I'm just reporting that in this case the pre-release tag is not the earliest tag, but it's being reported as the earliest tag.
I think maybe the order is coming back wrong or needs to be sorted differently?
release/0.5.13
includes the PR and is earlier than pre-release
We just ask GitHub for the order
Where does this happen? Maybe I can help debug.
from refined-github.
As a workaround I will maybe rename my pre-release
to nightly
, which comes before release
in alphabetical order. π€¦ Thanks for looking into this.
from refined-github.
@wookayin Oh yeah! π€¦
@fregante maybe this issue should be "closing-remarks
shows earliest tag alphabetically rather than chronologically".
i.e. you could see the same problem if the versioning scheme changes (even though none of them would necessarily be non-version tags)
from refined-github.
- Refer to #7206 (comment)
from refined-github.
Hi @fregante β I'm a little uncertain. I don't believe it's an issue of excluding or including pre-release tags.
My understanding is that the UI is supposed to show the earliest tag that included the PR in question. In my scenario, the earliest tag isn't the pre-release tag, it's the actual release tag; but the UI is showing the pre-release tag.
What am I missing?
Thank you!
from refined-github.
We just ask GitHub for the order, so you can change it by changing the time of creation of the tags. But the core logic remains: this pattern requires --force
, so it's not something we should support
from refined-github.
See the firstTag updater function: https://github.com/refined-github/refined-github/blob/main/source/features/closing-remarks.tsx
I wonder if GitHub is showing the tags in an unexpected order in the dom, I thought we were using the API. Probably there isn't an equivalent API.
from refined-github.
Should we reopen this bug since I don't think it's a dup of #7206?
from refined-github.
@aryairani Alphabetically, nightly
< pre-release
< release-*
< v
, so you might instead want a tag that comes after release
, i.e. s, t, u, v, w, ... I have a similar issue with you in #7206, where nightly
precedes v
.
from refined-github.
Ok, I guess I have my functioning workaround in place now, thanks to @wookayin's alphabet help, by calling my nightly tag trunk-build
, which comes after release/*
alphabetically. (I had called it my "trunk build" tag trunk
briefly, but ran into conflicts with the trunk
branch.)
from refined-github.
Related Issues (20)
- RGH is injecting code into websites other than Github. HOT 3
- Make collapsed diffs more visually distinct
- `link-to-changelog-file` : add link to changelog on tag and release UI cards HOT 1
- Add option to distinguish review required statuses when I've already reviewed the PR. HOT 1
- Duplicated `show/hide whitespace` and `Switch to unified view` overflow on the view.
- Ability to copy the source diff (raw file)
- Default to own fork on "Create pull request" if it exists and not a maintainer
- Keyboard shortcut to edit Pull Request description in Conversation tab
- No response while opening large file or PR HOT 1
- Option to toggle &type=source when clicking on Repositories HOT 2
- hide-user-forks description improvement
- How often does a change to GitHub break something in Refined GitHub? HOT 2
- Option to hide repositories and notifications of some organizations I belong to HOT 1
- Buttons misaligned in mobile Editor which makes them non-clickable HOT 2
- The draft icon for PRβs is invisible when using dark mode
- Filter for forks that are ahead HOT 1
- Odd Split Username Oval...Thing HOT 4
- Editable upload path
- Tags in commit list HOT 2
- `clean-conversation-sidebar`: incorrectly hides "open in workspace" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refined-github.