Exception when logging DbEntityValidationException about serilog.exceptions HOT 9 CLOSED

The exception is catched and the additional property is just not generated and appended...

from serilog.exceptions.

The problem are indexed properties which are not correctly handled:

Adding

.Where(x => x.CanRead && x.GetIndexParameters().Length == 0)

fixes this, but indexed properties are ignored...

from serilog.exceptions.

Created PR: #14

from serilog.exceptions.

also solves issue 12 I think.

from serilog.exceptions.

Unrelated to this very case, logging MUST NOT crash. Never. Seeing this just made me skip the whole project - I simply cannot affort my logging pipeline to crash with an exception and thus make me blind to potentially critical production issues (since I would have never observed them in dev/test). Whatever the framework does, everything should be in a try/catch block with a fallback...

Just my 0.02$
Philipp

from serilog.exceptions.

Awesome - I misinterpreted the post then. Thanks for the clarification!

from serilog.exceptions.

Apologies for not getting on top of this earlier. I was on holiday and later got distracted by life. I've now merged both PR's. Can you confirm everything works using the MyGet package and I'll arrange a release.

from serilog.exceptions.

I guess closing the issue means that all works well?

from serilog.exceptions.

I didnt test the myget package (feed url?) but I already use the PRs in production code and it works for me..

from serilog.exceptions.