Insert data from ex.data into output template about serilog.exceptions HOT 2 CLOSED

Hi @bxbxbx.

There are two major problems with your approach, let me explain each one separately.

The first issue is that exception message is not a template for Serilog. Whether you are using Serilog.Exceptions or not is not relevant.

The second issue is that you do not have to and, in fact, you should never pass ex.Message to as a messageTemplate argument of Serilog's log method. The proper way to use Serilog in your case would be:

var ex = new InvalidOperationException($"SubJob Status<>Startable");
ex.Data.Add("SubJobId", subJobId);
_logger.Fatal(ex, "There was a problem with SubJob with id {SubJobId}, subJobId);

Notice that Fatal method is accepting a proper messageTemplate and a parameter to fill the placeholder. On the other hand, the exception message is not a template, so there is no placeholder.

Is there anything else I could explain?

from serilog.exceptions.

Hello @krajek

thx for your elaborate answer.
This is a legacy project, so no IoC yet, but I'm working on that.
I was thinking that this was a way to avoid passing around the logger all the time, but I guess I will have to.

bye!

from serilog.exceptions.